diff mbox series

[FFmpeg-devel,2/2] avfilter/avfilter: Make ff_command_queue_pop() static

Message ID GV1P250MB0737CD2F11AFF75CFE39A6F98F4F9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit 5a7978a694e7cab4684181ca4020caf0ce8cbb06
Headers show
Series [FFmpeg-devel,1/2] avfilter/internal: Remove declaration of inexistent function | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 21, 2022, 2 a.m. UTC 
Only used here.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/avfilter.c | 6 +++---
 libavfilter/internal.h | 2 --
 2 files changed, 3 insertions(+), 5 deletions(-)

Comments

Nicolas George Sept. 21, 2022, 9:11 a.m. UTC | #1 
Andreas Rheinhardt (12022-09-21):
> Only used here.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavfilter/avfilter.c | 6 +++---
>  libavfilter/internal.h | 2 --
>  2 files changed, 3 insertions(+), 5 deletions(-)

Both patches look ok.

Regards,
diff mbox series

Patch

diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index f34204e650..cc5505e65b 100644
--- a/libavfilter/avfilter.c
+++ b/libavfilter/avfilter.c
@@ -78,7 +78,7 @@  static void tlog_ref(void *ctx, AVFrame *ref, int end)
 #endif
 }
 
-void ff_command_queue_pop(AVFilterContext *filter)
+static void command_queue_pop(AVFilterContext *filter)
 {
     AVFilterCommand *c= filter->command_queue;
     av_freep(&c->arg);
@@ -780,7 +780,7 @@  void avfilter_free(AVFilterContext *filter)
     av_freep(&filter->outputs);
     av_freep(&filter->priv);
     while(filter->command_queue){
-        ff_command_queue_pop(filter);
+        command_queue_pop(filter);
     }
     av_opt_free(filter);
     av_expr_free(filter->enable);
@@ -1494,7 +1494,7 @@  int ff_inlink_process_commands(AVFilterLink *link, const AVFrame *frame)
                "Processing command time:%f command:%s arg:%s\n",
                cmd->time, cmd->command, cmd->arg);
         avfilter_process_command(link->dst, cmd->command, cmd->arg, 0, 0, cmd->flags);
-        ff_command_queue_pop(link->dst);
+        command_queue_pop(link->dst);
         cmd= link->dst->command_queue;
     }
     return 0;
diff --git a/libavfilter/internal.h b/libavfilter/internal.h
index 36969c442e..aaf2c6c584 100644
--- a/libavfilter/internal.h
+++ b/libavfilter/internal.h
@@ -256,8 +256,6 @@  void ff_avfilter_link_set_in_status(AVFilterLink *link, int status, int64_t pts)
  */
 void ff_avfilter_link_set_out_status(AVFilterLink *link, int status, int64_t pts);
 
-void ff_command_queue_pop(AVFilterContext *filter);
-
 #define D2TS(d)      (isnan(d) ? AV_NOPTS_VALUE : (int64_t)(d))
 #define TS2D(ts)     ((ts) == AV_NOPTS_VALUE ? NAN : (double)(ts))
 #define TS2T(ts, tb) ((ts) == AV_NOPTS_VALUE ? NAN : (double)(ts) * av_q2d(tb))