| Message ID | GV1P250MB0737FB26AFDEB3185975E6D38FEB2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM |
|---|---|
| State | Accepted |
| Commit | 65763bffb6e2a7dbb281e302b7adf7ee7b5330a9 |
| Headers | show |
| Series | [FFmpeg-devel] avformat/mpegts: Don't use uninitialized value in av_log() | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
Andreas Rheinhardt: > It is undefined behaviour in (at least) C11 (see C11 6.3.2.1 (2)). > Fixes Coverity issue #1500314. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > libavformat/mpegts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c > index 3a5cb769ba..c66a1ea6ed 100644 > --- a/libavformat/mpegts.c > +++ b/libavformat/mpegts.c > @@ -2189,7 +2189,7 @@ int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type > uint32_t buf; > AVDOVIDecoderConfigurationRecord *dovi; > size_t dovi_size; > - int dependency_pid; > + int dependency_pid = -1; // Unset > > if (desc_end - *pp < 4) // (8 + 8 + 7 + 6 + 1 + 1 + 1) / 8 > return AVERROR_INVALIDDATA; Will apply tomorrow unless there are objections. - Andreas
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 3a5cb769ba..c66a1ea6ed 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2189,7 +2189,7 @@ int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type uint32_t buf; AVDOVIDecoderConfigurationRecord *dovi; size_t dovi_size; - int dependency_pid; + int dependency_pid = -1; // Unset if (desc_end - *pp < 4) // (8 + 8 + 7 + 6 + 1 + 1 + 1) / 8 return AVERROR_INVALIDDATA;
It is undefined behaviour in (at least) C11 (see C11 6.3.2.1 (2)). Fixes Coverity issue #1500314. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavformat/mpegts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)