diff mbox series

[FFmpeg-devel] avutil/version: Remove outdated checks

Message ID GV1SPRMB006305380400FD578650C0C78F522@GV1SPRMB0063.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit cb9f1f59a1db6f41494890ff23dec20325497c69
Headers show
Series [FFmpeg-devel] avutil/version: Remove outdated checks | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Feb. 18, 2024, 1:48 a.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavutil/version.c | 16 ----------------
 1 file changed, 16 deletions(-)

Comments

Andreas Rheinhardt Feb. 19, 2024, 11:23 p.m. UTC | #1 
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavutil/version.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/libavutil/version.c b/libavutil/version.c
> index 75c5c0d1a8..baead7c4a0 100644
> --- a/libavutil/version.c
> +++ b/libavutil/version.c
> @@ -18,14 +18,9 @@
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>   */
>  
> -#include <stdlib.h>
> -
>  #include "config.h"
>  #include "avassert.h"
>  #include "avutil.h"
> -#include "common.h"
> -#include "libm.h"
> -#include "log.h"
>  #include "samplefmt.h"
>  #include "version.h"
>  
> @@ -44,17 +39,6 @@ unsigned avutil_version(void)
>      av_assert0(AV_PICTURE_TYPE_BI == 7);
>      av_assert0(LIBAVUTIL_VERSION_MICRO >= 100);
>  
> -    av_assert0(((size_t)-1) > 0); // C guarantees this but if false on a platform we care about revert at least b284e1ffe343d6697fb950d1ee517bafda8a9844
> -
> -    if (av_sat_dadd32(1, 2) != 5) {
> -        av_log(NULL, AV_LOG_FATAL, "Libavutil has been built with a broken binutils, please upgrade binutils and rebuild\n");
> -        abort();
> -    }
> -
> -    if (llrint(1LL<<60) != 1LL<<60) {
> -        av_log(NULL, AV_LOG_ERROR, "Libavutil has been linked to a broken llrint()\n");
> -    }
> -
>      return LIBAVUTIL_VERSION_INT;
>  }
>  

Will apply this patch tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavutil/version.c b/libavutil/version.c
index 75c5c0d1a8..baead7c4a0 100644
--- a/libavutil/version.c
+++ b/libavutil/version.c
@@ -18,14 +18,9 @@ 
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
-#include <stdlib.h>
-
 #include "config.h"
 #include "avassert.h"
 #include "avutil.h"
-#include "common.h"
-#include "libm.h"
-#include "log.h"
 #include "samplefmt.h"
 #include "version.h"
 
@@ -44,17 +39,6 @@  unsigned avutil_version(void)
     av_assert0(AV_PICTURE_TYPE_BI == 7);
     av_assert0(LIBAVUTIL_VERSION_MICRO >= 100);
 
-    av_assert0(((size_t)-1) > 0); // C guarantees this but if false on a platform we care about revert at least b284e1ffe343d6697fb950d1ee517bafda8a9844
-
-    if (av_sat_dadd32(1, 2) != 5) {
-        av_log(NULL, AV_LOG_FATAL, "Libavutil has been built with a broken binutils, please upgrade binutils and rebuild\n");
-        abort();
-    }
-
-    if (llrint(1LL<<60) != 1LL<<60) {
-        av_log(NULL, AV_LOG_ERROR, "Libavutil has been linked to a broken llrint()\n");
-    }
-
     return LIBAVUTIL_VERSION_INT;
 }