diff mbox series

[FFmpeg-devel] fftools/ffmpeg_opt: Check creation of new program

Message ID HE1PR0101MB2219575CBC01A6136E8CF81C8F729@HE1PR0101MB2219.eurprd01.prod.exchangelabs.com
State Superseded
Headers show
Series [FFmpeg-devel] fftools/ffmpeg_opt: Check creation of new program | expand

Commit Message

Andreas Rheinhardt Aug. 25, 2022, 9:15 p.m. UTC 
Fixes Coverity issue #1512413.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 fftools/ffmpeg_opt.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Gyan Doshi Aug. 26, 2022, 5:02 a.m. UTC | #1 
On 2022-08-26 02:45 am, Andreas Rheinhardt wrote:
> Fixes Coverity issue #1512413.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   fftools/ffmpeg_opt.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 8128dcf9fb..aec94dc0f4 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -2769,6 +2769,8 @@ static void of_add_programs(AVFormatContext *oc, const OptionsContext *o)
>           }
>   
>           program = av_new_program(oc, progid);
> +        if (!program)
> +            exit_program(1);

Needs a log for the user why ffmpeg exits.

Regards,
Gyan
diff mbox series

Patch

diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 8128dcf9fb..aec94dc0f4 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -2769,6 +2769,8 @@  static void of_add_programs(AVFormatContext *oc, const OptionsContext *o)
         }
 
         program = av_new_program(oc, progid);
+        if (!program)
+            exit_program(1);
 
         p = o->program[i].u.str;
         while(*p) {