diff mbox series

[FFmpeg-devel,4/5] avcodec/libvorbisenc: Actually set error upon goto error

Message ID HE1PR0301MB215468F1CE89BC3350491D6B8F4D9@HE1PR0301MB2154.eurprd03.prod.outlook.com
State New
Headers show
Series [FFmpeg-devel,1/5] avcodec: Remove redundant freeing of extradata of encoders
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt April 15, 2021, 2:04 a.m. UTC
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/libvorbisenc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/libavcodec/libvorbisenc.c b/libavcodec/libvorbisenc.c
index b556280a95..061a4e9da7 100644
--- a/libavcodec/libvorbisenc.c
+++ b/libavcodec/libvorbisenc.c
@@ -263,7 +263,8 @@  static av_cold int libvorbis_encode_init(AVCodecContext *avctx)
     s->vp = av_vorbis_parse_init(avctx->extradata, avctx->extradata_size);
     if (!s->vp) {
         av_log(avctx, AV_LOG_ERROR, "invalid extradata\n");
-        return ret;
+        ret = AVERROR_UNKNOWN;
+        goto error;
     }
 
     avctx->frame_size = LIBVORBIS_FRAME_SIZE;