diff mbox series

[FFmpeg-devel,1/2] lavu/tx: add missing prints for the type of dctI/dstI

Message ID Ndchl_G--3-9@lynne.ee
State New
Headers show
Series [FFmpeg-devel,1/2] lavu/tx: add missing prints for the type of dctI/dstI | expand

Commit Message

Lynne Sept. 6, 2023, 4:19 a.m. UTC 
Forgot to add the new types to the print, currently
they fallback to "unknown".

Comments

Lynne Sept. 8, 2023, 4:59 a.m. UTC | #1 
Sep 6, 2023, 06:21 by dev@lynne.ee:

> The spec finally clarified the meaning of the field to:
>
>> maxLevelIdc is a StdVideoH264LevelIdc value specifying the maximum H.264 level supported by the profile, where enum constant STD_VIDEO_H264_LEVEL_IDC_<major>_<minor> identifies H.264 level <major>.<minor> as defined in section A.3 of the ITU-T H.264 Specification.1
>>
>
> Annoyingly, we have to convert it to an IDC value to compare it.
> Mesa commit:
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24649
> Only mesa currently uses the IDC value, all other drivers use the enum.
>
> Patch attached.
>

Pushed.
diff mbox series

Patch

From 439f1e881313ef63ecb8e8e264f4847d6612619d Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Sun, 3 Sep 2023 16:47:53 +0200
Subject: [PATCH 1/2] lavu/tx: add missing prints for the type of dctI/dstI

---
 libavutil/tx.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/libavutil/tx.c b/libavutil/tx.c
index e9826e6107..24b2015b44 100644
--- a/libavutil/tx.c
+++ b/libavutil/tx.c
@@ -578,12 +578,18 @@  static void print_type(AVBPrint *bp, enum AVTXType type)
                type == AV_TX_FLOAT_FFT   ? "fft_float"   :
                type == AV_TX_FLOAT_MDCT  ? "mdct_float"  :
                type == AV_TX_FLOAT_RDFT  ? "rdft_float"  :
+               type == AV_TX_FLOAT_DCT_I ? "dctI_float"  :
+               type == AV_TX_FLOAT_DST_I ? "dstI_float"  :
                type == AV_TX_DOUBLE_FFT  ? "fft_double"  :
                type == AV_TX_DOUBLE_MDCT ? "mdct_double" :
                type == AV_TX_DOUBLE_RDFT ? "rdft_double" :
+               type == AV_TX_DOUBLE_DCT_I ? "dctI_double" :
+               type == AV_TX_DOUBLE_DST_I ? "dstI_double" :
                type == AV_TX_INT32_FFT   ? "fft_int32"   :
                type == AV_TX_INT32_MDCT  ? "mdct_int32"  :
                type == AV_TX_INT32_RDFT  ? "rdft_int32"  :
+               type == AV_TX_INT32_DCT_I ? "dctI_int32" :
+               type == AV_TX_INT32_DST_I ? "dstI_int32" :
                "unknown");
 }
 
-- 
2.40.1