diff mbox series

[FFmpeg-devel,v2,1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes

Message ID OSZP286MB217316FD987CE83B6E5C8001CA092@OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM
State New
Headers show
Series [FFmpeg-devel,v2,1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Wu Jianhua April 15, 2024, 5:35 p.m. UTC 
From: Wu Jianhua <toqsxw@outlook.com>

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
---
 libavcodec/x86/vvc/vvcdsp_init.c | 35 +++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

Comments

Nuo Mi April 17, 2024, 1:14 p.m. UTC | #1 
Hi Jianhua,
thank you for the patches.
could you add a log for each commit to explain why we need this commit?


On Tue, Apr 16, 2024 at 1:36 AM <toqsxw@outlook.com> wrote:

> From: Wu Jianhua <toqsxw@outlook.com>
>
> Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
> ---
>  libavcodec/x86/vvc/vvcdsp_init.c | 35 +++++++++++++++++++++++++++++++-
>  1 file changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/x86/vvc/vvcdsp_init.c
> b/libavcodec/x86/vvc/vvcdsp_init.c
> index 23a3172c45..d9203f4d5f 100644
> --- a/libavcodec/x86/vvc/vvcdsp_init.c
> +++ b/libavcodec/x86/vvc/vvcdsp_init.c
> @@ -30,9 +30,42 @@
>  #include "libavcodec/vvc/dsp.h"
>  #include "libavcodec/x86/h26x/h2656dsp.h"
>
> +#define PUT_PROTOTYPE(name, depth, opt) \
> +void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const
> uint8_t *src, ptrdiff_t srcstride, int height, const int8_t *hf, const
> int8_t *vf, int width);
> +
> +#define PUT_PROTOTYPES(name, bitd, opt) \
> +        PUT_PROTOTYPE(name##2,   bitd, opt) \
> +        PUT_PROTOTYPE(name##4,   bitd, opt) \
> +        PUT_PROTOTYPE(name##8,   bitd, opt) \
> +        PUT_PROTOTYPE(name##12,  bitd, opt) \
> +        PUT_PROTOTYPE(name##16,  bitd, opt) \
> +        PUT_PROTOTYPE(name##24,  bitd, opt) \
> +        PUT_PROTOTYPE(name##32,  bitd, opt) \
> +        PUT_PROTOTYPE(name##48,  bitd, opt) \
> +        PUT_PROTOTYPE(name##64,  bitd, opt) \
> +        PUT_PROTOTYPE(name##128, bitd, opt)
> +
> +#define PUT_BPC_PROTOTYPES(name, opt) \
> +    PUT_PROTOTYPES(name,  8, opt)     \
> +    PUT_PROTOTYPES(name, 10, opt)     \
> +    PUT_PROTOTYPES(name, 12, opt)
> +
> +#define PUT_TAP_PROTOTYPES(n, opt) \
> +    PUT_BPC_PROTOTYPES(n##tap_h,  opt) \
> +    PUT_BPC_PROTOTYPES(n##tap_v,  opt) \
> +    PUT_BPC_PROTOTYPES(n##tap_hv, opt)
> +
> +PUT_BPC_PROTOTYPES(pixels, sse4)
> +PUT_BPC_PROTOTYPES(pixels, avx2)
> +
> +PUT_TAP_PROTOTYPES(4, sse4)
> +PUT_TAP_PROTOTYPES(8, sse4)
> +PUT_TAP_PROTOTYPES(4, avx2)
> +PUT_TAP_PROTOTYPES(8, avx2)
> +
>  #if ARCH_X86_64
>  #define FW_PUT(name, depth, opt) \
> -static void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst,
> const uint8_t *src, ptrdiff_t srcstride, \
> +void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const
> uint8_t *src, ptrdiff_t srcstride,        \
>                                                   int height, const int8_t
> *hf, const int8_t *vf, int width)    \
>  {
>                                       \
>      ff_h2656_put_## name ## _ ## depth ## _##opt(dst, 2 * MAX_PB_SIZE,
> src, srcstride, height, hf, vf, width); \
> --
> 2.44.0.windows.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Wu Jianhua April 17, 2024, 6:30 p.m. UTC | #2 
> 发件人: Nuo Mi <nuomi2021@gmail.com>
> 发送时间: 2024年4月17日 6:14
> 收件人: FFmpeg development discussions and patches
> 抄送: Wu Jianhua
> 主题: Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes
> 
> Hi Jianhua,
> thank you for the patches.
> could you add a log for each commit to explain why we need this commit?

Sure. v3 sent.

> 
> On Tue, Apr 16, 2024 at 1:36 AM <toqsxw@outlook.com<mailto:toqsxw@outlook.com>> wrote:
> From: Wu Jianhua <toqsxw@outlook.com<mailto:toqsxw@outlook.com>>
> 
> Signed-off-by: Wu Jianhua <toqsxw@outlook.com<mailto:toqsxw@outlook.com>>
> ---
>  libavcodec/x86/vvc/vvcdsp_init.c | 35 +++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
Nuo Mi April 20, 2024, 1:38 p.m. UTC | #3 
On Thu, Apr 18, 2024 at 2:30 AM Wu Jianhua <toqsxw@outlook.com> wrote:

> > 发件人: Nuo Mi <nuomi2021@gmail.com>
> > 发送时间: 2024年4月17日 6:14
> > 收件人: FFmpeg development discussions and patches
> > 抄送: Wu Jianhua
> > 主题: Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add
> put prototypes
> >
> > Hi Jianhua,
> > thank you for the patches.
> > could you add a log for each commit to explain why we need this commit?
>
> Sure. v3 sent.
>
Thank you. v3 applied.

>
> >
> > On Tue, Apr 16, 2024 at 1:36 AM <toqsxw@outlook.com<mailto:
> toqsxw@outlook.com>> wrote:
> > From: Wu Jianhua <toqsxw@outlook.com<mailto:toqsxw@outlook.com>>
> >
> > Signed-off-by: Wu Jianhua <toqsxw@outlook.com<mailto:toqsxw@outlook.com
> >>
> > ---
> >  libavcodec/x86/vvc/vvcdsp_init.c | 35 +++++++++++++++++++++++++++++++-
> > 1 file changed, 34 insertions(+), 1 deletion(-)
>
>
diff mbox series

Patch

diff --git a/libavcodec/x86/vvc/vvcdsp_init.c b/libavcodec/x86/vvc/vvcdsp_init.c
index 23a3172c45..d9203f4d5f 100644
--- a/libavcodec/x86/vvc/vvcdsp_init.c
+++ b/libavcodec/x86/vvc/vvcdsp_init.c
@@ -30,9 +30,42 @@ 
 #include "libavcodec/vvc/dsp.h"
 #include "libavcodec/x86/h26x/h2656dsp.h"
 
+#define PUT_PROTOTYPE(name, depth, opt) \
+void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const uint8_t *src, ptrdiff_t srcstride, int height, const int8_t *hf, const int8_t *vf, int width);
+
+#define PUT_PROTOTYPES(name, bitd, opt) \
+        PUT_PROTOTYPE(name##2,   bitd, opt) \
+        PUT_PROTOTYPE(name##4,   bitd, opt) \
+        PUT_PROTOTYPE(name##8,   bitd, opt) \
+        PUT_PROTOTYPE(name##12,  bitd, opt) \
+        PUT_PROTOTYPE(name##16,  bitd, opt) \
+        PUT_PROTOTYPE(name##24,  bitd, opt) \
+        PUT_PROTOTYPE(name##32,  bitd, opt) \
+        PUT_PROTOTYPE(name##48,  bitd, opt) \
+        PUT_PROTOTYPE(name##64,  bitd, opt) \
+        PUT_PROTOTYPE(name##128, bitd, opt)
+
+#define PUT_BPC_PROTOTYPES(name, opt) \
+    PUT_PROTOTYPES(name,  8, opt)     \
+    PUT_PROTOTYPES(name, 10, opt)     \
+    PUT_PROTOTYPES(name, 12, opt)
+
+#define PUT_TAP_PROTOTYPES(n, opt) \
+    PUT_BPC_PROTOTYPES(n##tap_h,  opt) \
+    PUT_BPC_PROTOTYPES(n##tap_v,  opt) \
+    PUT_BPC_PROTOTYPES(n##tap_hv, opt)
+
+PUT_BPC_PROTOTYPES(pixels, sse4)
+PUT_BPC_PROTOTYPES(pixels, avx2)
+
+PUT_TAP_PROTOTYPES(4, sse4)
+PUT_TAP_PROTOTYPES(8, sse4)
+PUT_TAP_PROTOTYPES(4, avx2)
+PUT_TAP_PROTOTYPES(8, avx2)
+
 #if ARCH_X86_64
 #define FW_PUT(name, depth, opt) \
-static void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const uint8_t *src, ptrdiff_t srcstride, \
+void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const uint8_t *src, ptrdiff_t srcstride,        \
                                                  int height, const int8_t *hf, const int8_t *vf, int width)    \
 {                                                                                                              \
     ff_h2656_put_## name ## _ ## depth ## _##opt(dst, 2 * MAX_PB_SIZE, src, srcstride, height, hf, vf, width); \