diff mbox series

[FFmpeg-devel,109/218] avfilter/vf_signature: Use formats list instead of query function

Message ID PR3PR03MB66654BB5EA3035D554FD22868FAA9@PR3PR03MB6665.eurprd03.prod.outlook.com
State Accepted
Commit f4ea416a131cd715d7df04def5b678a217484c4d
Headers show
Series [FFmpeg-devel,001/218] avfilter/f_reverse: Don't use redundant query_formats function | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 30, 2021, 1:40 p.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_signature.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Paul B Mahol Oct. 4, 2021, 9:29 a.m. UTC | #1 
whole patchset LGTM
Andreas Rheinhardt Oct. 4, 2021, 9:50 a.m. UTC | #2 
Paul B Mahol:
> whole patchset LGTM
> 

Thanks for the review. I will apply it in two days in case anyone else
wants to chime in.

- Andreas
diff mbox series

Patch

diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c
index 03b53f9a4c..2b55f7fe67 100644
--- a/libavfilter/vf_signature.c
+++ b/libavfilter/vf_signature.c
@@ -69,8 +69,6 @@  static const AVOption signature_options[] = {
 
 AVFILTER_DEFINE_CLASS(signature);
 
-static int query_formats(AVFilterContext *ctx)
-{
     /* all formats with a separate gray value */
     static const enum AVPixelFormat pix_fmts[] = {
         AV_PIX_FMT_GRAY8,
@@ -84,9 +82,6 @@  static int query_formats(AVFilterContext *ctx)
         AV_PIX_FMT_NONE
     };
 
-    return ff_set_common_formats_from_list(ctx, pix_fmts);
-}
-
 static int config_input(AVFilterLink *inlink)
 {
     AVFilterContext *ctx = inlink->dst;
@@ -762,6 +757,6 @@  const AVFilter ff_vf_signature = {
     .uninit        = uninit,
     FILTER_OUTPUTS(signature_outputs),
     .inputs        = NULL,
-    FILTER_QUERY_FUNC(query_formats),
+    FILTER_PIXFMTS_ARRAY(pix_fmts),
     .flags         = AVFILTER_FLAG_DYNAMIC_INPUTS,
 };