diff mbox series

[FFmpeg-devel] configure: use just the pkg-config for sndio

Message ID ZI0H-2z8sQIrAeFw@humpty.home.comstyle.com
State New
Headers show
Series [FFmpeg-devel] configure: use just the pkg-config for sndio | expand

Checks

Context Check Description
yinshiyou/configure_loongarch64 warning Failed to run configure
andriy/configure_x86 warning Failed to run configure

Commit Message

Brad Smith June 17, 2023, 1:10 a.m. UTC
---
 configure | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Michael Niedermayer June 17, 2023, 10:01 p.m. UTC | #1
On Fri, Jun 16, 2023 at 09:10:19PM -0400, Brad Smith wrote:
> 
> ---
>  configure | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 0c77d8e1fe..653aafb1ea 100755
> --- a/configure
> +++ b/configure
> @@ -7009,8 +7009,7 @@ enabled alsa && { check_pkg_config alsa alsa "alsa/asoundlib.h" snd_pcm_htimesta
>  enabled libjack &&
>      require_pkg_config libjack jack jack/jack.h jack_port_get_latency_range
>  
> -enabled sndio && { check_pkg_config sndio sndio "sndio.h" sio_open ||
> -                   check_lib sndio sndio.h sio_open -lsndio; }
> +enabled sndio && require_pkg_config sndio sndio sndio.h sio_open

this breaks a plain configure
here on ubuntu

./configure
ERROR: sndio not found using pkg-config

If you think configure made a mistake, make sure you are using the latest
version from Git.  If the latest version fails, report the problem to the
ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
Include the log file "ffbuild/config.log" produced by configure as this will help
solve the problem.



[...]
Brad Smith June 17, 2023, 10:48 p.m. UTC | #2
On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote:
> 
> this breaks a plain configure
> here on ubuntu
> 
> ./configure
> ERROR: sndio not found using pkg-config
> 
> If you think configure made a mistake, make sure you are using the latest
> version from Git.  If the latest version fails, report the problem to the
> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
> Include the log file "ffbuild/config.log" produced by configure as this will help
> solve the problem.
> 
> 
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The misfortune of the wise is better than the prosperity of the fool.
> -- Epicurus


This is what I had intended.

---
 configure | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/configure b/configure
index 0c77d8e1fe..2069bf8a37 100755
--- a/configure
+++ b/configure
@@ -7009,8 +7009,7 @@ enabled alsa && { check_pkg_config alsa alsa "alsa/asoundlib.h" snd_pcm_htimesta
 enabled libjack &&
     require_pkg_config libjack jack jack/jack.h jack_port_get_latency_range
 
-enabled sndio && { check_pkg_config sndio sndio "sndio.h" sio_open ||
-                   check_lib sndio sndio.h sio_open -lsndio; }
+enabled sndio && check_pkg_config sndio sndio sndio.h sio_open
 
 if enabled libcdio; then
     check_pkg_config libcdio libcdio_paranoia "cdio/cdda.h cdio/paranoia.h" cdio_cddap_open ||
Brad Smith June 23, 2023, 10:41 p.m. UTC | #3
ping.

On 2023-06-17 6:48 p.m., Brad Smith wrote:
> On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote:
>> this breaks a plain configure
>> here on ubuntu
>>
>> ./configure
>> ERROR: sndio not found using pkg-config
>>
>> If you think configure made a mistake, make sure you are using the latest
>> version from Git.  If the latest version fails, report the problem to the
>> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
>> Include the log file "ffbuild/config.log" produced by configure as this will help
>> solve the problem.
>>
>>
>>
>> [...]
>> -- 
>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>
>> The misfortune of the wise is better than the prosperity of the fool.
>> -- Epicurus
>
> This is what I had intended.
>
> ---
>   configure | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 0c77d8e1fe..2069bf8a37 100755
> --- a/configure
> +++ b/configure
> @@ -7009,8 +7009,7 @@ enabled alsa && { check_pkg_config alsa alsa "alsa/asoundlib.h" snd_pcm_htimesta
>   enabled libjack &&
>       require_pkg_config libjack jack jack/jack.h jack_port_get_latency_range
>   
> -enabled sndio && { check_pkg_config sndio sndio "sndio.h" sio_open ||
> -                   check_lib sndio sndio.h sio_open -lsndio; }
> +enabled sndio && check_pkg_config sndio sndio sndio.h sio_open
>   
>   if enabled libcdio; then
>       check_pkg_config libcdio libcdio_paranoia "cdio/cdda.h cdio/paranoia.h" cdio_cddap_open ||
Michael Niedermayer June 23, 2023, 10:55 p.m. UTC | #4
On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
> ping.
> 
> On 2023-06-17 6:48 p.m., Brad Smith wrote:
> > On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote:
> > > this breaks a plain configure
> > > here on ubuntu
> > > 
> > > ./configure
> > > ERROR: sndio not found using pkg-config
> > > 
> > > If you think configure made a mistake, make sure you are using the latest
> > > version from Git.  If the latest version fails, report the problem to the
> > > ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
> > > Include the log file "ffbuild/config.log" produced by configure as this will help
> > > solve the problem.
> > > 
> > > 
> > > 
> > > [...]
> > > -- 
> > > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> > > 
> > > The misfortune of the wise is better than the prosperity of the fool.
> > > -- Epicurus
> > 
> > This is what I had intended.

You intended to break a plain ./configure on ubuntu ?
If so i think we better dont apply that patch :)

thx

[...]
Brad Smith June 23, 2023, 10:56 p.m. UTC | #5
On 2023-06-23 6:55 p.m., Michael Niedermayer wrote:
> On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
>> ping.
>>
>> On 2023-06-17 6:48 p.m., Brad Smith wrote:
>>> On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote:
>>>> this breaks a plain configure
>>>> here on ubuntu
>>>>
>>>> ./configure
>>>> ERROR: sndio not found using pkg-config
>>>>
>>>> If you think configure made a mistake, make sure you are using the latest
>>>> version from Git.  If the latest version fails, report the problem to the
>>>> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
>>>> Include the log file "ffbuild/config.log" produced by configure as this will help
>>>> solve the problem.
>>>>
>>>>
>>>>
>>>> [...]
>>>> -- 
>>>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>>>
>>>> The misfortune of the wise is better than the prosperity of the fool.
>>>> -- Epicurus
>>> This is what I had intended.
> You intended to break a plain ./configure on ubuntu ?
> If so i think we better dont apply that patch :)
>
> thx

No, there was a second patch there.
James Almer June 23, 2023, 10:56 p.m. UTC | #6
On 6/23/2023 7:55 PM, Michael Niedermayer wrote:
> On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
>> ping.
>>
>> On 2023-06-17 6:48 p.m., Brad Smith wrote:
>>> On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote:
>>>> this breaks a plain configure
>>>> here on ubuntu
>>>>
>>>> ./configure
>>>> ERROR: sndio not found using pkg-config
>>>>
>>>> If you think configure made a mistake, make sure you are using the latest
>>>> version from Git.  If the latest version fails, report the problem to the
>>>> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
>>>> Include the log file "ffbuild/config.log" produced by configure as this will help
>>>> solve the problem.
>>>>
>>>>
>>>>
>>>> [...]
>>>> -- 
>>>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>>>
>>>> The misfortune of the wise is better than the prosperity of the fool.
>>>> -- Epicurus
>>>
>>> This is what I had intended.
> 
> You intended to break a plain ./configure on ubuntu ?
> If so i think we better dont apply that patch :)
> 
> thx

He means the updated version he pasted right below that line.
Michael Niedermayer June 23, 2023, 11:35 p.m. UTC | #7
On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote:
> On 2023-06-23 6:55 p.m., Michael Niedermayer wrote:
> > On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
> > > ping.
> > > 
> > > On 2023-06-17 6:48 p.m., Brad Smith wrote:
> > > > On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote:
> > > > > this breaks a plain configure
> > > > > here on ubuntu
> > > > > 
> > > > > ./configure
> > > > > ERROR: sndio not found using pkg-config
> > > > > 
> > > > > If you think configure made a mistake, make sure you are using the latest
> > > > > version from Git.  If the latest version fails, report the problem to the
> > > > > ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
> > > > > Include the log file "ffbuild/config.log" produced by configure as this will help
> > > > > solve the problem.
> > > > > 
> > > > > 
> > > > > 
> > > > > [...]
> > > > > -- 
> > > > > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> > > > > 
> > > > > The misfortune of the wise is better than the prosperity of the fool.
> > > > > -- Epicurus
> > > > This is what I had intended.
> > You intended to break a plain ./configure on ubuntu ?
> > If so i think we better dont apply that patch :)
> > 
> > thx
> 
> No, there was a second patch there.

oops i missed that, the 2nd patch works fine on ubuntu
no objections from me

thx

[...]
Brad Smith June 23, 2023, 11:36 p.m. UTC | #8
On 2023-06-23 7:35 p.m., Michael Niedermayer wrote:
> On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote:
>> On 2023-06-23 6:55 p.m., Michael Niedermayer wrote:
>>> On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
>>>> ping.
>>>>
>>>> On 2023-06-17 6:48 p.m., Brad Smith wrote:
>>>>> On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote:
>>>>>> this breaks a plain configure
>>>>>> here on ubuntu
>>>>>>
>>>>>> ./configure
>>>>>> ERROR: sndio not found using pkg-config
>>>>>>
>>>>>> If you think configure made a mistake, make sure you are using the latest
>>>>>> version from Git.  If the latest version fails, report the problem to the
>>>>>> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
>>>>>> Include the log file "ffbuild/config.log" produced by configure as this will help
>>>>>> solve the problem.
>>>>>>
>>>>>>
>>>>>>
>>>>>> [...]
>>>>>> -- 
>>>>>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>>>>>
>>>>>> The misfortune of the wise is better than the prosperity of the fool.
>>>>>> -- Epicurus
>>>>> This is what I had intended.
>>> You intended to break a plain ./configure on ubuntu ?
>>> If so i think we better dont apply that patch :)
>>>
>>> thx
>> No, there was a second patch there.
> oops i missed that, the 2nd patch works fine on ubuntu
> no objections from me
>
> thx


Thanks.
Brad Smith July 1, 2023, 6:58 p.m. UTC | #9
On 2023-06-23 7:36 p.m., Brad Smith wrote:
> On 2023-06-23 7:35 p.m., Michael Niedermayer wrote:
>> On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote:
>>> On 2023-06-23 6:55 p.m., Michael Niedermayer wrote:
>>>> On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
>>>>> ping.
>>>>>
>>>>> On 2023-06-17 6:48 p.m., Brad Smith wrote:
>>>>>> On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote:
>>>>>>> this breaks a plain configure
>>>>>>> here on ubuntu
>>>>>>>
>>>>>>> ./configure
>>>>>>> ERROR: sndio not found using pkg-config
>>>>>>>
>>>>>>> If you think configure made a mistake, make sure you are using 
>>>>>>> the latest
>>>>>>> version from Git.  If the latest version fails, report the 
>>>>>>> problem to the
>>>>>>> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on 
>>>>>>> irc.libera.chat.
>>>>>>> Include the log file "ffbuild/config.log" produced by configure 
>>>>>>> as this will help
>>>>>>> solve the problem.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> [...]
>>>>>>> -- 
>>>>>>> Michael     GnuPG fingerprint: 
>>>>>>> 9FF2128B147EF6730BADF133611EC787040B0FAB
>>>>>>>
>>>>>>> The misfortune of the wise is better than the prosperity of the 
>>>>>>> fool.
>>>>>>> -- Epicurus
>>>>>> This is what I had intended.
>>>> You intended to break a plain ./configure on ubuntu ?
>>>> If so i think we better dont apply that patch :)
>>>>
>>>> thx
>>> No, there was a second patch there.
>> oops i missed that, the 2nd patch works fine on ubuntu
>> no objections from me
>>
>> thx


ping.
Brad Smith July 7, 2023, 7:16 p.m. UTC | #10
On 2023-07-01 2:58 p.m., Brad Smith wrote:
> On 2023-06-23 7:36 p.m., Brad Smith wrote:
>> On 2023-06-23 7:35 p.m., Michael Niedermayer wrote:
>>> On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote:
>>>> On 2023-06-23 6:55 p.m., Michael Niedermayer wrote:
>>>>> On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
>>>>>> ping.
>>>>>>
>>>>>> On 2023-06-17 6:48 p.m., Brad Smith wrote:
>>>>>>> On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer 
>>>>>>> wrote:
>>>>>>>> this breaks a plain configure
>>>>>>>> here on ubuntu
>>>>>>>>
>>>>>>>> ./configure
>>>>>>>> ERROR: sndio not found using pkg-config
>>>>>>>>
>>>>>>>> If you think configure made a mistake, make sure you are using 
>>>>>>>> the latest
>>>>>>>> version from Git.  If the latest version fails, report the 
>>>>>>>> problem to the
>>>>>>>> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on 
>>>>>>>> irc.libera.chat.
>>>>>>>> Include the log file "ffbuild/config.log" produced by configure 
>>>>>>>> as this will help
>>>>>>>> solve the problem.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> [...]
>>>>>>>> -- 
>>>>>>>> Michael     GnuPG fingerprint: 
>>>>>>>> 9FF2128B147EF6730BADF133611EC787040B0FAB
>>>>>>>>
>>>>>>>> The misfortune of the wise is better than the prosperity of the 
>>>>>>>> fool.
>>>>>>>> -- Epicurus
>>>>>>> This is what I had intended.
>>>>> You intended to break a plain ./configure on ubuntu ?
>>>>> If so i think we better dont apply that patch :)
>>>>>
>>>>> thx
>>>> No, there was a second patch there.
>>> oops i missed that, the 2nd patch works fine on ubuntu
>>> no objections from me
>>>
>>> thx
>
>
> ping.
>

ping.
Brad Smith July 20, 2023, 7:17 p.m. UTC | #11
On 7/7/2023 3:16 PM, Brad Smith wrote:
> On 2023-07-01 2:58 p.m., Brad Smith wrote:
>> On 2023-06-23 7:36 p.m., Brad Smith wrote:
>>> On 2023-06-23 7:35 p.m., Michael Niedermayer wrote:
>>>> On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote:
>>>>> On 2023-06-23 6:55 p.m., Michael Niedermayer wrote:
>>>>>> On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
>>>>>>> ping.
>>>>>>>
>>>>>>> On 2023-06-17 6:48 p.m., Brad Smith wrote:
>>>>>>>> On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer 
>>>>>>>> wrote:
>>>>>>>>> this breaks a plain configure
>>>>>>>>> here on ubuntu
>>>>>>>>>
>>>>>>>>> ./configure
>>>>>>>>> ERROR: sndio not found using pkg-config
>>>>>>>>>
>>>>>>>>> If you think configure made a mistake, make sure you are using 
>>>>>>>>> the latest
>>>>>>>>> version from Git.  If the latest version fails, report the 
>>>>>>>>> problem to the
>>>>>>>>> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on 
>>>>>>>>> irc.libera.chat.
>>>>>>>>> Include the log file "ffbuild/config.log" produced by 
>>>>>>>>> configure as this will help
>>>>>>>>> solve the problem.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> [...]
>>>>>>>>> -- 
>>>>>>>>> Michael     GnuPG fingerprint: 
>>>>>>>>> 9FF2128B147EF6730BADF133611EC787040B0FAB
>>>>>>>>>
>>>>>>>>> The misfortune of the wise is better than the prosperity of 
>>>>>>>>> the fool.
>>>>>>>>> -- Epicurus
>>>>>>>> This is what I had intended.
>>>>>> You intended to break a plain ./configure on ubuntu ?
>>>>>> If so i think we better dont apply that patch :)
>>>>>>
>>>>>> thx
>>>>> No, there was a second patch there.
>>>> oops i missed that, the 2nd patch works fine on ubuntu
>>>> no objections from me
>>>>
>>>> thx
>>
>>
>> ping.
>>
>
> ping.


ping.
Brad Smith Aug. 7, 2023, 7:04 p.m. UTC | #12
On 2023-07-20 3:17 p.m., Brad Smith wrote:
> On 7/7/2023 3:16 PM, Brad Smith wrote:
>> On 2023-07-01 2:58 p.m., Brad Smith wrote:
>>> On 2023-06-23 7:36 p.m., Brad Smith wrote:
>>>> On 2023-06-23 7:35 p.m., Michael Niedermayer wrote:
>>>>> On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote:
>>>>>> On 2023-06-23 6:55 p.m., Michael Niedermayer wrote:
>>>>>>> On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
>>>>>>>> ping.
>>>>>>>>
>>>>>>>> On 2023-06-17 6:48 p.m., Brad Smith wrote:
>>>>>>>>> On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer 
>>>>>>>>> wrote:
>>>>>>>>>> this breaks a plain configure
>>>>>>>>>> here on ubuntu
>>>>>>>>>>
>>>>>>>>>> ./configure
>>>>>>>>>> ERROR: sndio not found using pkg-config
>>>>>>>>>>
>>>>>>>>>> If you think configure made a mistake, make sure you are 
>>>>>>>>>> using the latest
>>>>>>>>>> version from Git.  If the latest version fails, report the 
>>>>>>>>>> problem to the
>>>>>>>>>> ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on 
>>>>>>>>>> irc.libera.chat.
>>>>>>>>>> Include the log file "ffbuild/config.log" produced by 
>>>>>>>>>> configure as this will help
>>>>>>>>>> solve the problem.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> [...]
>>>>>>>>>> -- 
>>>>>>>>>> Michael     GnuPG fingerprint: 
>>>>>>>>>> 9FF2128B147EF6730BADF133611EC787040B0FAB
>>>>>>>>>>
>>>>>>>>>> The misfortune of the wise is better than the prosperity of 
>>>>>>>>>> the fool.
>>>>>>>>>> -- Epicurus
>>>>>>>>> This is what I had intended.
>>>>>>> You intended to break a plain ./configure on ubuntu ?
>>>>>>> If so i think we better dont apply that patch :)
>>>>>>>
>>>>>>> thx
>>>>>> No, there was a second patch there.
>>>>> oops i missed that, the 2nd patch works fine on ubuntu
>>>>> no objections from me
>>>>>
>>>>> thx
>>>
>>>
>>> ping.
>>>
>>
>> ping.
>
>
> ping.


Is there something wrong with the patch?
Michael Niedermayer Aug. 7, 2023, 7:30 p.m. UTC | #13
On Mon, Aug 07, 2023 at 03:04:35PM -0400, Brad Smith wrote:
> On 2023-07-20 3:17 p.m., Brad Smith wrote:
> > On 7/7/2023 3:16 PM, Brad Smith wrote:
> > > On 2023-07-01 2:58 p.m., Brad Smith wrote:
> > > > On 2023-06-23 7:36 p.m., Brad Smith wrote:
> > > > > On 2023-06-23 7:35 p.m., Michael Niedermayer wrote:
> > > > > > On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote:
> > > > > > > On 2023-06-23 6:55 p.m., Michael Niedermayer wrote:
> > > > > > > > On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
> > > > > > > > > ping.
> > > > > > > > > 
> > > > > > > > > On 2023-06-17 6:48 p.m., Brad Smith wrote:
> > > > > > > > > > On Sun, Jun 18, 2023 at 12:01:14AM
> > > > > > > > > > +0200, Michael Niedermayer wrote:
> > > > > > > > > > > this breaks a plain configure
> > > > > > > > > > > here on ubuntu
> > > > > > > > > > > 
> > > > > > > > > > > ./configure
> > > > > > > > > > > ERROR: sndio not found using pkg-config
> > > > > > > > > > > 
> > > > > > > > > > > If you think configure made a
> > > > > > > > > > > mistake, make sure you are using the
> > > > > > > > > > > latest
> > > > > > > > > > > version from Git.  If the latest
> > > > > > > > > > > version fails, report the problem to
> > > > > > > > > > > the
> > > > > > > > > > > ffmpeg-user@ffmpeg.org mailing list
> > > > > > > > > > > or IRC #ffmpeg on irc.libera.chat.
> > > > > > > > > > > Include the log file
> > > > > > > > > > > "ffbuild/config.log" produced by
> > > > > > > > > > > configure as this will help
> > > > > > > > > > > solve the problem.
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > [...]
> > > > > > > > > > > -- 
> > > > > > > > > > > Michael     GnuPG fingerprint:
> > > > > > > > > > > 9FF2128B147EF6730BADF133611EC787040B0FAB
> > > > > > > > > > > 
> > > > > > > > > > > The misfortune of the wise is better
> > > > > > > > > > > than the prosperity of the fool.
> > > > > > > > > > > -- Epicurus
> > > > > > > > > > This is what I had intended.
> > > > > > > > You intended to break a plain ./configure on ubuntu ?
> > > > > > > > If so i think we better dont apply that patch :)
> > > > > > > > 
> > > > > > > > thx
> > > > > > > No, there was a second patch there.
> > > > > > oops i missed that, the 2nd patch works fine on ubuntu
> > > > > > no objections from me
> > > > > > 
> > > > > > thx
> > > > 
> > > > 
> > > > ping.
> > > > 
> > > 
> > > ping.
> > 
> > 
> > ping.
> 
> 
> Is there something wrong with the patch?

no, i was just a bit hesitant because i didnt know if anyone or anything
would depend on that removed case

ill apply it

thx

[...]
Brad Smith Aug. 7, 2023, 7:32 p.m. UTC | #14
On 2023-08-07 3:30 p.m., Michael Niedermayer wrote:
> On Mon, Aug 07, 2023 at 03:04:35PM -0400, Brad Smith wrote:
>> On 2023-07-20 3:17 p.m., Brad Smith wrote:
>>> On 7/7/2023 3:16 PM, Brad Smith wrote:
>>>> On 2023-07-01 2:58 p.m., Brad Smith wrote:
>>>>> On 2023-06-23 7:36 p.m., Brad Smith wrote:
>>>>>> On 2023-06-23 7:35 p.m., Michael Niedermayer wrote:
>>>>>>> On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote:
>>>>>>>> On 2023-06-23 6:55 p.m., Michael Niedermayer wrote:
>>>>>>>>> On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote:
>>>>>>>>>> ping.
>>>>>>>>>>
>>>>>>>>>> On 2023-06-17 6:48 p.m., Brad Smith wrote:
>>>>>>>>>>> On Sun, Jun 18, 2023 at 12:01:14AM
>>>>>>>>>>> +0200, Michael Niedermayer wrote:
>>>>>>>>>>>> this breaks a plain configure
>>>>>>>>>>>> here on ubuntu
>>>>>>>>>>>>
>>>>>>>>>>>> ./configure
>>>>>>>>>>>> ERROR: sndio not found using pkg-config
>>>>>>>>>>>>
>>>>>>>>>>>> If you think configure made a
>>>>>>>>>>>> mistake, make sure you are using the
>>>>>>>>>>>> latest
>>>>>>>>>>>> version from Git.  If the latest
>>>>>>>>>>>> version fails, report the problem to
>>>>>>>>>>>> the
>>>>>>>>>>>> ffmpeg-user@ffmpeg.org mailing list
>>>>>>>>>>>> or IRC #ffmpeg on irc.libera.chat.
>>>>>>>>>>>> Include the log file
>>>>>>>>>>>> "ffbuild/config.log" produced by
>>>>>>>>>>>> configure as this will help
>>>>>>>>>>>> solve the problem.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> [...]
>>>>>>>>>>>> -- 
>>>>>>>>>>>> Michael     GnuPG fingerprint:
>>>>>>>>>>>> 9FF2128B147EF6730BADF133611EC787040B0FAB
>>>>>>>>>>>>
>>>>>>>>>>>> The misfortune of the wise is better
>>>>>>>>>>>> than the prosperity of the fool.
>>>>>>>>>>>> -- Epicurus
>>>>>>>>>>> This is what I had intended.
>>>>>>>>> You intended to break a plain ./configure on ubuntu ?
>>>>>>>>> If so i think we better dont apply that patch :)
>>>>>>>>>
>>>>>>>>> thx
>>>>>>>> No, there was a second patch there.
>>>>>>> oops i missed that, the 2nd patch works fine on ubuntu
>>>>>>> no objections from me
>>>>>>>
>>>>>>> thx
>>>>>
>>>>> ping.
>>>>>
>>>> ping.
>>>
>>> ping.
>>
>> Is there something wrong with the patch?
> no, i was just a bit hesitant because i didnt know if anyone or anything
> would depend on that removed case
>
> ill apply it
>
> thx

Ah, Ok. I was wondering what the issue was since there was no further 
communication.

Thank you.
diff mbox series

Patch

diff --git a/configure b/configure
index 0c77d8e1fe..653aafb1ea 100755
--- a/configure
+++ b/configure
@@ -7009,8 +7009,7 @@  enabled alsa && { check_pkg_config alsa alsa "alsa/asoundlib.h" snd_pcm_htimesta
 enabled libjack &&
     require_pkg_config libjack jack jack/jack.h jack_port_get_latency_range
 
-enabled sndio && { check_pkg_config sndio sndio "sndio.h" sio_open ||
-                   check_lib sndio sndio.h sio_open -lsndio; }
+enabled sndio && require_pkg_config sndio sndio sndio.h sio_open
 
 if enabled libcdio; then
     check_pkg_config libcdio libcdio_paranoia "cdio/cdda.h cdio/paranoia.h" cdio_cddap_open ||