diff mbox series

[FFmpeg-devel] enable 'dvh1' FourCC in MP4

Message ID ZJsbHjE6q6kvj5wQ@sakura.greysector.net
State New
Headers show
Series [FFmpeg-devel] enable 'dvh1' FourCC in MP4 | expand

Checks

Context Check Description
andriy/configure_x86 warning Failed to apply patch
yinshiyou/configure_loongarch64 warning Failed to apply patch

Commit Message

Dominik 'Rathann' Mierzejewski June 27, 2023, 5:23 p.m. UTC
Hi!
I'm forwarding this patch from HandBrake. Original author is
Damiano Galassi (galad87@github).

Apparently, this is required to pass through Dolby Vision metadata
to x265. Author's comment says: 'Profile 5 seems to require the "dvh1"
fourcc.' See https://github.com/HandBrake/HandBrake/pull/4838 for more
details.


Regards,
Dominik

Comments

Dominik 'Rathann' Mierzejewski June 27, 2023, 5:37 p.m. UTC | #1
On Tuesday, 27 June 2023 at 19:23, Dominik 'Rathann' Mierzejewski wrote:
> Hi!
> I'm forwarding this patch from HandBrake. Original author is
> Damiano Galassi (galad87@github).
> 
> Apparently, this is required to pass through Dolby Vision metadata
> to x265. Author's comment says: 'Profile 5 seems to require the "dvh1"
> fourcc.' See https://github.com/HandBrake/HandBrake/pull/4838 for more
> details.

It looks like this might fix https://trac.ffmpeg.org/ticket/10257 .

Regards,
Dominik
Dominik 'Rathann' Mierzejewski Sept. 6, 2023, 8:23 a.m. UTC | #2
On Tuesday, 27 June 2023 at 19:37, Dominik 'Rathann' Mierzejewski wrote:
> On Tuesday, 27 June 2023 at 19:23, Dominik 'Rathann' Mierzejewski wrote:
> > Hi!
> > I'm forwarding this patch from HandBrake. Original author is
> > Damiano Galassi (galad87@github).
> > 
> > Apparently, this is required to pass through Dolby Vision metadata
> > to x265. Author's comment says: 'Profile 5 seems to require the "dvh1"
> > fourcc.' See https://github.com/HandBrake/HandBrake/pull/4838 for more
> > details.
> 
> It looks like this might fix https://trac.ffmpeg.org/ticket/10257 .

Rebased on top of current master and attached.

Regards,
Dominik
diff mbox series

Patch

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 5608afd..f46df18 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -7689,6 +7689,7 @@  static const AVCodecTag codec_mp4_tags[] = {
     { AV_CODEC_ID_H264,            MKTAG('a', 'v', 'c', '3') },
     { AV_CODEC_ID_HEVC,            MKTAG('h', 'e', 'v', '1') },
     { AV_CODEC_ID_HEVC,            MKTAG('h', 'v', 'c', '1') },
+    { AV_CODEC_ID_HEVC,            MKTAG('d', 'v', 'h', '1') },
     { AV_CODEC_ID_MPEG2VIDEO,      MKTAG('m', 'p', '4', 'v') },
     { AV_CODEC_ID_MPEG1VIDEO,      MKTAG('m', 'p', '4', 'v') },
     { AV_CODEC_ID_MJPEG,           MKTAG('m', 'p', '4', 'v') },