diff mbox series

[FFmpeg-devel] configure: Enable section_data_rel_ro for FreeBSD and NetBSD aarch64 / arm

Message ID ZX-s77W_x6RhRrkP@humpty.home.comstyle.com
State New
Headers show
Series [FFmpeg-devel] configure: Enable section_data_rel_ro for FreeBSD and NetBSD aarch64 / arm | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Brad Smith Dec. 18, 2023, 2:22 a.m. UTC
configure: Enable section_data_rel_ro for FreeBSD and NetBSD aarch64 / arm

Signed-off-by: Brad Smith <brad@comstyle.com>
---
 configure | 2 ++
 1 file changed, 2 insertions(+)

Comments

Brad Smith Dec. 24, 2023, 6:22 p.m. UTC | #1
ping.

On 2023-12-17 9:22 p.m., Brad Smith wrote:
> configure: Enable section_data_rel_ro for FreeBSD and NetBSD aarch64 / arm
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
>   configure | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/configure b/configure
> index 078aa9437a..226874600a 100755
> --- a/configure
> +++ b/configure
> @@ -5601,6 +5601,7 @@ case $target_os in
>           ;;
>       netbsd)
>           disable symver
> +        enable section_data_rel_ro
>           oss_indev_extralibs="-lossaudio"
>           oss_outdev_extralibs="-lossaudio"
>           enabled gcc || check_ldflags -Wl,-zmuldefs
> @@ -5619,6 +5620,7 @@ case $target_os in
>           disable symver
>           ;;
>       freebsd)
> +        enable section_data_rel_ro
>           ;;
>       bsd/os)
>           add_extralibs -lpoll -lgnugetopt
Michael Niedermayer Dec. 24, 2023, 6:58 p.m. UTC | #2
Hi

On Sun, Dec 17, 2023 at 09:22:39PM -0500, Brad Smith wrote:
> configure: Enable section_data_rel_ro for FreeBSD and NetBSD aarch64 / arm

The commit message should be a bit more verbose.
Explaining "why" even if thats obvious to you

thx

[...]
Brad Smith Dec. 24, 2023, 7:35 p.m. UTC | #3
On 2023-12-24 1:58 p.m., Michael Niedermayer wrote:
> Hi
>
> On Sun, Dec 17, 2023 at 09:22:39PM -0500, Brad Smith wrote:
>> configure: Enable section_data_rel_ro for FreeBSD and NetBSD aarch64 / arm
> The commit message should be a bit more verbose.
> Explaining "why" even if thats obvious to you
>
> thx

Done.
diff mbox series

Patch

diff --git a/configure b/configure
index 078aa9437a..226874600a 100755
--- a/configure
+++ b/configure
@@ -5601,6 +5601,7 @@  case $target_os in
         ;;
     netbsd)
         disable symver
+        enable section_data_rel_ro
         oss_indev_extralibs="-lossaudio"
         oss_outdev_extralibs="-lossaudio"
         enabled gcc || check_ldflags -Wl,-zmuldefs
@@ -5619,6 +5620,7 @@  case $target_os in
         disable symver
         ;;
     freebsd)
+        enable section_data_rel_ro
         ;;
     bsd/os)
         add_extralibs -lpoll -lgnugetopt