| Message ID | ZjhM1sRdNVJNOrP7@humpty.home.comstyle.com |
|---|---|
| State | Accepted |
| Commit | 115c96b9bd53e775f425f23d5b73fa0a9dedbd08 |
| Headers | show |
| Series | [FFmpeg-devel] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Hi Brad, On Sun, May 5, 2024 at 11:22 PM Brad Smith <brad-at-comstyle.com@ffmpeg.org> wrote: > > avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD > > Use the machdep.altivec sysctl on NetBSD for AltiVec detection > as is done with OpenBSD. > > Signed-off-by: Brad Smith <brad@comstyle.com> > --- > libavutil/ppc/cpu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c > index bc8bb5f47c..2b13cda662 100644 > --- a/libavutil/ppc/cpu.c > +++ b/libavutil/ppc/cpu.c > @@ -27,7 +27,7 @@ > #if HAVE_UNISTD_H > #include <unistd.h> > #endif > -#elif defined(__OpenBSD__) > +#elif defined(__NetBSD__) || defined(__OpenBSD__) > #include <sys/types.h> > #include <sys/sysctl.h> > #include <machine/cpu.h> > @@ -56,8 +56,8 @@ int ff_get_cpu_flags_ppc(void) > if (result == VECTORTYPE_ALTIVEC) > return AV_CPU_FLAG_ALTIVEC; > return 0; > -#elif defined(__APPLE__) || defined(__OpenBSD__) > -#ifdef __OpenBSD__ > +#elif defined(__APPLE__) || defined(__NetBSD__) || defined(__OpenBSD__) > +#if defined(__NetBSD__) || defined(__OpenBSD__) > int sels[2] = {CTL_MACHDEP, CPU_ALTIVEC}; > #else > int sels[2] = {CTL_HW, HW_VECTORUNIT}; > -- > 2.44.0 > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". OK, looks good to me. -- Sean McGovern
On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: > avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD > > Use the machdep.altivec sysctl on NetBSD for AltiVec detection > as is done with OpenBSD. > > Signed-off-by: Brad Smith <brad@comstyle.com> > --- > libavutil/ppc/cpu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) you seem to be sending alot of bsd related patches, maybe you want to send a patch that adds you to the MAINTAINERs file? thx [...]
On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: > On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: >> avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD >> >> Use the machdep.altivec sysctl on NetBSD for AltiVec detection >> as is done with OpenBSD. >> >> Signed-off-by: Brad Smith<brad@comstyle.com> >> --- >> libavutil/ppc/cpu.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > you seem to be sending alot of bsd related patches, maybe > you want to send a patch that adds you to the MAINTAINERs file? > > thx I try to help where I can. I am an OpenBSD developer and take a look at what the other *BSD's have for local patches and push things upstream to benefit both sides, but I am not sure I have enough time to be in a position to be considered any kind of official MAINTAINER.
On Sat, May 11, 2024 at 03:55:44PM -0400, Brad Smith wrote: > On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: > > On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: > > > avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD > > > > > > Use the machdep.altivec sysctl on NetBSD for AltiVec detection > > > as is done with OpenBSD. > > > > > > Signed-off-by: Brad Smith<brad@comstyle.com> > > > --- > > > libavutil/ppc/cpu.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > you seem to be sending alot of bsd related patches, maybe > > you want to send a patch that adds you to the MAINTAINERs file? > > > > thx > > I try to help where I can. I am an OpenBSD developer and take a look at > what the other *BSD's have for local patches and push things upstream to > benefit both sides, but I am not sure I have enough time to be in a position > to be considered any kind of official MAINTAINER. Iam not asking you to do more work Id like to give you a git write account so you can push your BSD related fixes yourself. (everyone who has git write should be in MAINTAINERs) thx [...]
On 2024-05-11 5:49 p.m., Michael Niedermayer wrote: > On Sat, May 11, 2024 at 03:55:44PM -0400, Brad Smith wrote: >> On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: >>> On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: >>>> avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD >>>> >>>> Use the machdep.altivec sysctl on NetBSD for AltiVec detection >>>> as is done with OpenBSD. >>>> >>>> Signed-off-by: Brad Smith<brad@comstyle.com> >>>> --- >>>> libavutil/ppc/cpu.c | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> you seem to be sending alot of bsd related patches, maybe >>> you want to send a patch that adds you to the MAINTAINERs file? >>> >>> thx >> I try to help where I can. I am an OpenBSD developer and take a look at >> what the other *BSD's have for local patches and push things upstream to >> benefit both sides, but I am not sure I have enough time to be in a position >> to be considered any kind of official MAINTAINER. > Iam not asking you to do more work > Id like to give you a git write account so you can push your BSD related > fixes yourself. > (everyone who has git write should be in MAINTAINERs) > > thx Oh, my misunderstanding. I would be fine with that.
Hi On Sat, May 11, 2024 at 06:24:32PM -0400, Brad Smith wrote: > On 2024-05-11 5:49 p.m., Michael Niedermayer wrote: > > On Sat, May 11, 2024 at 03:55:44PM -0400, Brad Smith wrote: > > > On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: > > > > On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: > > > > > avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD > > > > > > > > > > Use the machdep.altivec sysctl on NetBSD for AltiVec detection > > > > > as is done with OpenBSD. > > > > > > > > > > Signed-off-by: Brad Smith<brad@comstyle.com> > > > > > --- > > > > > libavutil/ppc/cpu.c | 6 +++--- > > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > you seem to be sending alot of bsd related patches, maybe > > > > you want to send a patch that adds you to the MAINTAINERs file? > > > > > > > > thx > > > I try to help where I can. I am an OpenBSD developer and take a look at > > > what the other *BSD's have for local patches and push things upstream to > > > benefit both sides, but I am not sure I have enough time to be in a position > > > to be considered any kind of official MAINTAINER. > > Iam not asking you to do more work > > Id like to give you a git write account so you can push your BSD related > > fixes yourself. > > (everyone who has git write should be in MAINTAINERs) > > > > thx > > Oh, my misunderstanding. I would be fine with that. Than please post a patch that adds you to MAINTAINERs the idea behind this is so that teh whole community can always object anyone receiving git wriet access I can post a patch adding you too, but i dont know what exactly you want listed in it. For git write it just matters that you are in the file anywhere thx [...]
On 2024-05-11 8:13 p.m., Michael Niedermayer wrote: > Hi > > On Sat, May 11, 2024 at 06:24:32PM -0400, Brad Smith wrote: >> On 2024-05-11 5:49 p.m., Michael Niedermayer wrote: >>> On Sat, May 11, 2024 at 03:55:44PM -0400, Brad Smith wrote: >>>> On 2024-05-06 10:24 p.m., Michael Niedermayer wrote: >>>>> On Sun, May 05, 2024 at 11:21:58PM -0400, Brad Smith wrote: >>>>>> avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD >>>>>> >>>>>> Use the machdep.altivec sysctl on NetBSD for AltiVec detection >>>>>> as is done with OpenBSD. >>>>>> >>>>>> Signed-off-by: Brad Smith<brad@comstyle.com> >>>>>> --- >>>>>> libavutil/ppc/cpu.c | 6 +++--- >>>>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>>> you seem to be sending alot of bsd related patches, maybe >>>>> you want to send a patch that adds you to the MAINTAINERs file? >>>>> >>>>> thx >>>> I try to help where I can. I am an OpenBSD developer and take a look at >>>> what the other *BSD's have for local patches and push things upstream to >>>> benefit both sides, but I am not sure I have enough time to be in a position >>>> to be considered any kind of official MAINTAINER. >>> Iam not asking you to do more work >>> Id like to give you a git write account so you can push your BSD related >>> fixes yourself. >>> (everyone who has git write should be in MAINTAINERs) >>> >>> thx >> Oh, my misunderstanding. I would be fine with that. > Than please post a patch that adds you to MAINTAINERs > the idea behind this is so that teh whole community can always > object anyone receiving git wriet access > I can post a patch adding you too, but i dont know what exactly > you want listed in it. For git write it just matters that you are > in the file anywhere > > thx Thanks. Will do.
diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c index bc8bb5f47c..2b13cda662 100644 --- a/libavutil/ppc/cpu.c +++ b/libavutil/ppc/cpu.c @@ -27,7 +27,7 @@ #if HAVE_UNISTD_H #include <unistd.h> #endif -#elif defined(__OpenBSD__) +#elif defined(__NetBSD__) || defined(__OpenBSD__) #include <sys/types.h> #include <sys/sysctl.h> #include <machine/cpu.h> @@ -56,8 +56,8 @@ int ff_get_cpu_flags_ppc(void) if (result == VECTORTYPE_ALTIVEC) return AV_CPU_FLAG_ALTIVEC; return 0; -#elif defined(__APPLE__) || defined(__OpenBSD__) -#ifdef __OpenBSD__ +#elif defined(__APPLE__) || defined(__NetBSD__) || defined(__OpenBSD__) +#if defined(__NetBSD__) || defined(__OpenBSD__) int sels[2] = {CTL_MACHDEP, CPU_ALTIVEC}; #else int sels[2] = {CTL_HW, HW_VECTORUNIT};
avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD Use the machdep.altivec sysctl on NetBSD for AltiVec detection as is done with OpenBSD. Signed-off-by: Brad Smith <brad@comstyle.com> --- libavutil/ppc/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)