diff mbox series

[FFmpeg-devel] configure: enable ffnvcodec, nvenc, nvdec for FreeBSD

Message ID ZklBB8dkGLbpnJ0x@humpty.home.comstyle.com
State Accepted
Commit 43b1a956789bf0d5796769427d40c78e460c247f
Headers show
Series [FFmpeg-devel] configure: enable ffnvcodec, nvenc, nvdec for FreeBSD | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Brad Smith May 19, 2024, midnight UTC
configure: enable ffnvcodec, nvenc, nvdec for FreeBSD

Signed-off-by: Brad Smith <brad@comstyle.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Timo Rothenpieler May 19, 2024, 11:24 a.m. UTC | #1
On 19.05.2024 02:00, Brad Smith wrote:
> configure: enable ffnvcodec, nvenc, nvdec for FreeBSD
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index b16722d83d..96b181fd21 100755
> --- a/configure
> +++ b/configure
> @@ -7350,7 +7350,7 @@ fi
>   
>   if enabled x86; then
>       case $target_os in
> -        mingw32*|mingw64*|win32|win64|linux|cygwin*)
> +        freebsd|mingw32*|mingw64*|win32|win64|linux|cygwin*)

Does this actually work?
Everything I find online indicates that the FreeBSD driver is lacking 
support for CUDA, nvenc and most of anything compute related.
Brad Smith May 26, 2024, 5:22 a.m. UTC | #2
On 2024-05-19 7:24 a.m., Timo Rothenpieler wrote:
> On 19.05.2024 02:00, Brad Smith wrote:
>> configure: enable ffnvcodec, nvenc, nvdec for FreeBSD
>>
>> Signed-off-by: Brad Smith <brad@comstyle.com>
>> ---
>>   configure | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index b16722d83d..96b181fd21 100755
>> --- a/configure
>> +++ b/configure
>> @@ -7350,7 +7350,7 @@ fi
>>     if enabled x86; then
>>       case $target_os in
>> -        mingw32*|mingw64*|win32|win64|linux|cygwin*)
>> +        freebsd|mingw32*|mingw64*|win32|win64|linux|cygwin*)
>
> Does this actually work?
> Everything I find online indicates that the FreeBSD driver is lacking 
> support for CUDA, nvenc and most of anything compute related.


According to the commits and bug report requesting support it does 
appear to work.

The CUDA bits are not native. They're using Linux emulation for that. 
The display driver is
native.
Timo Rothenpieler May 26, 2024, 11:28 a.m. UTC | #3
On 26.05.2024 07:22, Brad Smith wrote:
> On 2024-05-19 7:24 a.m., Timo Rothenpieler wrote:
>> On 19.05.2024 02:00, Brad Smith wrote:
>>> configure: enable ffnvcodec, nvenc, nvdec for FreeBSD
>>>
>>> Signed-off-by: Brad Smith <brad@comstyle.com>
>>> ---
>>>   configure | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index b16722d83d..96b181fd21 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -7350,7 +7350,7 @@ fi
>>>     if enabled x86; then
>>>       case $target_os in
>>> -        mingw32*|mingw64*|win32|win64|linux|cygwin*)
>>> +        freebsd|mingw32*|mingw64*|win32|win64|linux|cygwin*)
>>
>> Does this actually work?
>> Everything I find online indicates that the FreeBSD driver is lacking 
>> support for CUDA, nvenc and most of anything compute related.
> 
> 
> According to the commits and bug report requesting support it does 
> appear to work.
> 
> The CUDA bits are not native. They're using Linux emulation for that. 
> The display driver is
> native.

If it actually is confirmed to work, this change LGTM.
I have no way to test or verify that though.
diff mbox series

Patch

diff --git a/configure b/configure
index b16722d83d..96b181fd21 100755
--- a/configure
+++ b/configure
@@ -7350,7 +7350,7 @@  fi
 
 if enabled x86; then
     case $target_os in
-        mingw32*|mingw64*|win32|win64|linux|cygwin*)
+        freebsd|mingw32*|mingw64*|win32|win64|linux|cygwin*)
             ;;
         *)
             disable ffnvcodec cuvid nvdec nvenc