| Message ID | a68ca9a4-356b-4af1-99ec-541dce6f9c5b@amyspark.me |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,v2] avdevice: Fix disabling audiotoolbox_outdev build on iOS | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Ping for review. amyspark On 29/07/2023 16:00, L. E. Segovia wrote: > audiotoolbox.m uses CoreAudio APIs that are only available in macOS. > The existing CoreAudio framework check is already enough for this case > (as CoreAudio.h does not exist for the iDevices), however, it was never > passed as a dependency of audiotoolbox_outdev. This caused the > build system to include that output device into the targets. > > Signed-off-by: L. E. Segovia <amy@amyspark.me> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 99388e7664..ccb9d7be7a 100755 > --- a/configure > +++ b/configure > @@ -3577,7 +3577,7 @@ alsa_outdev_deps="alsa" > avfoundation_indev_deps="avfoundation corevideo coremedia pthreads" > avfoundation_indev_suggest="coregraphics applicationservices" > avfoundation_indev_extralibs="-framework Foundation" > -audiotoolbox_outdev_deps="audiotoolbox pthreads" > +audiotoolbox_outdev_deps="audiotoolbox coreaudio pthreads" > audiotoolbox_outdev_extralibs="-framework AudioToolbox -framework CoreAudio" > bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h" > caca_outdev_deps="libcaca"
Ping again for review. amyspark On 29/07/2023 16:00, L. E. Segovia wrote: > audiotoolbox.m uses CoreAudio APIs that are only available in macOS. > The existing CoreAudio framework check is already enough for this case > (as CoreAudio.h does not exist for the iDevices), however, it was never > passed as a dependency of audiotoolbox_outdev. This caused the > build system to include that output device into the targets. > > Signed-off-by: L. E. Segovia <amy@amyspark.me> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 99388e7664..ccb9d7be7a 100755 > --- a/configure > +++ b/configure > @@ -3577,7 +3577,7 @@ alsa_outdev_deps="alsa" > avfoundation_indev_deps="avfoundation corevideo coremedia pthreads" > avfoundation_indev_suggest="coregraphics applicationservices" > avfoundation_indev_extralibs="-framework Foundation" > -audiotoolbox_outdev_deps="audiotoolbox pthreads" > +audiotoolbox_outdev_deps="audiotoolbox coreaudio pthreads" > audiotoolbox_outdev_extralibs="-framework AudioToolbox -framework CoreAudio" > bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h" > caca_outdev_deps="libcaca"
diff --git a/configure b/configure index 99388e7664..ccb9d7be7a 100755 --- a/configure +++ b/configure @@ -3577,7 +3577,7 @@ alsa_outdev_deps="alsa" avfoundation_indev_deps="avfoundation corevideo coremedia pthreads" avfoundation_indev_suggest="coregraphics applicationservices" avfoundation_indev_extralibs="-framework Foundation" -audiotoolbox_outdev_deps="audiotoolbox pthreads" +audiotoolbox_outdev_deps="audiotoolbox coreaudio pthreads" audiotoolbox_outdev_extralibs="-framework AudioToolbox -framework CoreAudio" bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h" caca_outdev_deps="libcaca"
audiotoolbox.m uses CoreAudio APIs that are only available in macOS. The existing CoreAudio framework check is already enough for this case (as CoreAudio.h does not exist for the iDevices), however, it was never passed as a dependency of audiotoolbox_outdev. This caused the build system to include that output device into the targets. Signed-off-by: L. E. Segovia <amy@amyspark.me> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)