diff mbox series

[FFmpeg-devel] lavf/webmdashenc.c: Allow AV1 video in WebM

Message ID ac804c41-f2d6-a443-4505-61398f1cceff@mail.de
State Accepted
Headers show
Series [FFmpeg-devel] lavf/webmdashenc.c: Allow AV1 video in WebM
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Thilo Borgmann June 13, 2021, 7:46 p.m. UTC
Hi,

not sure about the spec backing this up, however the following site lists AV1 
support in WebM:
https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Video_codecs

-Thilo
From fa6a57486d7fc2cb4d110db05b0b231a2c3046e6 Mon Sep 17 00:00:00 2001
From: Matthieu Patou <mpatou@fb.com>
Date: Sun, 13 Jun 2021 21:41:06 +0200
Subject: [PATCH] lavf/webmdashenc.c: Allow AV1 video in WebM

Suggested-By: ffmpeg@fb.com
---
 libavformat/webmdashenc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

James Zern June 17, 2021, 8:14 p.m. UTC | #1
Hi,

On Sun, Jun 13, 2021 at 12:46 PM Thilo Borgmann <thilo.borgmann@mail.de> wrote:
>
> Hi,
>
> not sure about the spec backing this up, however the following site lists AV1
> support in WebM:
> https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Video_codecs
>

This should probably get a version bump.

I think this change makes sense. The matroska muxer and other tools
have supported AV1 for a while and matroska has defined the mapping
in:
https://github.com/ietf-wg-cellar/matroska-specification/blob/HEAD/codec/av1.md

webmproject.org should probably be updated to match:
https://bugs.chromium.org/p/webm/issues/detail?id=1734
Thilo Borgmann June 20, 2021, 8:31 p.m. UTC | #2
Am 17.06.21 um 22:14 schrieb James Zern:
> Hi,
> 
> On Sun, Jun 13, 2021 at 12:46 PM Thilo Borgmann <thilo.borgmann@mail.de> wrote:
>>
>> Hi,
>>
>> not sure about the spec backing this up, however the following site lists AV1
>> support in WebM:
>> https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Video_codecs
>>
> 
> This should probably get a version bump.
> 
> I think this change makes sense. The matroska muxer and other tools
> have supported AV1 for a while and matroska has defined the mapping
> in:
> https://github.com/ietf-wg-cellar/matroska-specification/blob/HEAD/codec/av1.md
> 
> webmproject.org should probably be updated to match:
> https://bugs.chromium.org/p/webm/issues/detail?id=1734

Pushed with Micro bump.

Thanks!
-Thilo
diff mbox series

Patch

diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c
index 6f9622a..cf69bd3 100644
--- a/libavformat/webmdashenc.c
+++ b/libavformat/webmdashenc.c
@@ -480,7 +480,8 @@  static int webm_dash_manifest_write_header(AVFormatContext *s)
     for (unsigned i = 0; i < s->nb_streams; i++) {
         enum AVCodecID codec_id = s->streams[i]->codecpar->codec_id;
         if (codec_id != AV_CODEC_ID_VP8    && codec_id != AV_CODEC_ID_VP9 &&
-            codec_id != AV_CODEC_ID_VORBIS && codec_id != AV_CODEC_ID_OPUS)
+            codec_id != AV_CODEC_ID_AV1    && codec_id != AV_CODEC_ID_VORBIS &&
+            codec_id != AV_CODEC_ID_OPUS)
             return AVERROR(EINVAL);
     }