diff mbox series

[FFmpeg-devel,3/4] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM

Message ID f47029231cf0a63ca70793bf3714e9bb9d8a9ae4.1667325395.git.amy@amyspark.me
State New
Headers show
Series Fix FFmpeg compilation without DCE | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

L. E. Segovia Nov. 1, 2022, 9:59 p.m. UTC 
Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a

Signed-off-by: L. E. Segovia <amy@amyspark.me>
---
 libavcodec/x86/vc1dsp_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Rheinhardt Nov. 2, 2022, 12:42 a.m. UTC | #1 
L. E. Segovia:
> Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a
> 
> Signed-off-by: L. E. Segovia <amy@amyspark.me>
> ---
>  libavcodec/x86/vc1dsp_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/x86/vc1dsp_init.c b/libavcodec/x86/vc1dsp_init.c
> index bc63933e83..65fc28ea35 100644
> --- a/libavcodec/x86/vc1dsp_init.c
> +++ b/libavcodec/x86/vc1dsp_init.c
> @@ -102,7 +102,7 @@ av_cold void ff_vc1dsp_init_x86(VC1DSPContext *dsp)
>  {
>      int cpu_flags = av_get_cpu_flags();
>  
> -#if HAVE_6REGS
> +#if HAVE_6REGS && HAVE_INLINE_ASM
>      if (INLINE_MMX(cpu_flags))
>          if (EXTERNAL_MMX(cpu_flags))
>          ff_vc1dsp_init_mmx(dsp);

There is also a check for EXTERNAL_MMX for which you add no #if check
here or in the next commit.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/x86/vc1dsp_init.c b/libavcodec/x86/vc1dsp_init.c
index bc63933e83..65fc28ea35 100644
--- a/libavcodec/x86/vc1dsp_init.c
+++ b/libavcodec/x86/vc1dsp_init.c
@@ -102,7 +102,7 @@  av_cold void ff_vc1dsp_init_x86(VC1DSPContext *dsp)
 {
     int cpu_flags = av_get_cpu_flags();
 
-#if HAVE_6REGS
+#if HAVE_6REGS && HAVE_INLINE_ASM
     if (INLINE_MMX(cpu_flags))
         if (EXTERNAL_MMX(cpu_flags))
         ff_vc1dsp_init_mmx(dsp);