diff mbox

[FFmpeg-devel,1/2] examples/vaapi_encode: Remove redundancy check when free context.

Message ID f66fcf5a-9678-75c9-9d1b-5ce908184166@gmail.com
State Accepted
Commit 9b955eece610f7f8b4aa2096b4e0ca738e21edc4
Headers show

Commit Message

Jun Zhao Jan. 11, 2018, 7:07 a.m. UTC
From ef424745ce8d425859e9ca16dd9aca72297ed90a Mon Sep 17 00:00:00 2001
From: Jun Zhao <jun.zhao@intel.com>
Date: Thu, 11 Jan 2018 13:21:58 +0800
Subject: [PATCH 1/2] examples/vaapi_encode: Remove redundancy check when free
 context.

avcodec_free_context have handle NULL pointer case, so caller doesn't
need to check the NULL before call this function.

Signe-off-by: Jun Zhao <jun.zhao@intel.com>
---
 doc/examples/vaapi_encode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Michael Niedermayer Jan. 12, 2018, 11:31 a.m. UTC | #1
On Thu, Jan 11, 2018 at 03:07:18PM +0800, Jun Zhao wrote:
> 

>  vaapi_encode.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 6002024418a485e89bb71fac812f5c540a434cf5  0001-examples-vaapi_encode-Remove-redundancy-check-when-f.patch
> From ef424745ce8d425859e9ca16dd9aca72297ed90a Mon Sep 17 00:00:00 2001
> From: Jun Zhao <jun.zhao@intel.com>
> Date: Thu, 11 Jan 2018 13:21:58 +0800
> Subject: [PATCH 1/2] examples/vaapi_encode: Remove redundancy check when free
>  context.
> 
> avcodec_free_context have handle NULL pointer case, so caller doesn't
> need to check the NULL before call this function.
> 
> Signe-off-by: Jun Zhao <jun.zhao@intel.com>
> ---
>  doc/examples/vaapi_encode.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/doc/examples/vaapi_encode.c b/doc/examples/vaapi_encode.c
> index f66a4a7c48..6425b1c98c 100644
> --- a/doc/examples/vaapi_encode.c
> +++ b/doc/examples/vaapi_encode.c
> @@ -217,8 +217,7 @@ close:
>          fclose(fout);
>      av_frame_free(&sw_frame);
>      av_frame_free(&hw_frame);
> -    if (avctx)
> -        avcodec_free_context(&avctx);
> +    avcodec_free_context(&avctx);
>      av_buffer_unref(&hw_device_ctx);

will apply

thx

[...]
diff mbox

Patch

diff --git a/doc/examples/vaapi_encode.c b/doc/examples/vaapi_encode.c
index f66a4a7c48..6425b1c98c 100644
--- a/doc/examples/vaapi_encode.c
+++ b/doc/examples/vaapi_encode.c
@@ -217,8 +217,7 @@  close:
         fclose(fout);
     av_frame_free(&sw_frame);
     av_frame_free(&hw_frame);
-    if (avctx)
-        avcodec_free_context(&avctx);
+    avcodec_free_context(&avctx);
     av_buffer_unref(&hw_device_ctx);
 
     return err;