diff mbox

[FFmpeg-devel,1/2] tests/audiomatch: Add return value check for fread.

Message ID ff3d18af-6f8f-1a3e-375f-3d9668f0f2b2@gmail.com
State Accepted
Commit 2b38900cb377c56d855807012d931c7c40d215ed
Headers show

Commit Message

Jun Zhao Dec. 18, 2017, 1:41 a.m. UTC
From a89964e88080d1cc6e01c99bf8640a1020465762 Mon Sep 17 00:00:00 2001
From: Jun Zhao <jun.zhao@intel.com>
Date: Mon, 18 Dec 2017 08:59:58 +0800
Subject: [PATCH 1/2] tests/audiomatch: Add return value check for fread.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Check fread return value to fix build warning as "ignoring
return value of ‘fread’"

Signed-off-by: Jun Zhao <jun.zhao@intel.com>
---
 tests/audiomatch.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Michael Niedermayer Dec. 19, 2017, 8:06 p.m. UTC | #1
On Mon, Dec 18, 2017 at 09:41:00AM +0800, Jun Zhao wrote:
> 

>  audiomatch.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> f7cd009b9c616d48223793eeab8d135329a23f69  0001-tests-audiomatch-Add-return-value-check-for-fread.patch
> From a89964e88080d1cc6e01c99bf8640a1020465762 Mon Sep 17 00:00:00 2001
> From: Jun Zhao <jun.zhao@intel.com>
> Date: Mon, 18 Dec 2017 08:59:58 +0800
> Subject: [PATCH 1/2] tests/audiomatch: Add return value check for fread.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Check fread return value to fix build warning as "ignoring
> return value of ‘fread’"
> 
> Signed-off-by: Jun Zhao <jun.zhao@intel.com>
> ---
>  tests/audiomatch.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

will apply

thanks

[...]
diff mbox

Patch

diff --git a/tests/audiomatch.c b/tests/audiomatch.c
index ca56df09b3..e63e494add 100644
--- a/tests/audiomatch.c
+++ b/tests/audiomatch.c
@@ -80,8 +80,10 @@  int main(int argc, char **argv){
     data   = malloc(datlen * sizeof(*data));
     signal = malloc(siglen * sizeof(*signal));
 
-    fread(data  , 1, datlen, f[0]);
-    fread(signal, 1, siglen, f[1]);
+    if (fread(data  , 1, datlen, f[0]) != datlen)
+        return 1;
+    if (fread(signal, 1, siglen, f[1]) != siglen)
+        return 1;
     datlen /= 2;
     siglen /= 2;