| Message ID | pull.20.ffstaging.FFmpeg.1642727870274.ffmpegagent@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] libavutil/tests/md5: Avoid warnings | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
| andriy/make_ppc | success | Make finished |
| andriy/make_fate_ppc | fail | Make fate failed |
| andriy/make_armv7_RPi4 | success | Make finished |
| andriy/make_fate_armv7_RPi4 | success | Make fate finished |
| andriy/make_aarch64_jetson | success | Make finished |
| andriy/make_fate_aarch64_jetson | success | Make fate finished |
Am Fr., 21. Jan. 2022 um 02:18 Uhr schrieb softworkz <ffmpegagent@gmail.com>: > > From: softworkz <softworkz@hotmail.com> > > Those are always showing up on Patchwork > when FATE tests are failing, covering > some possibly more useful information. > > Signed-off-by: softworkz <softworkz@hotmail.com> > --- > libavutil/tests/md5: Avoid warnings > > Those are always showing up on Patchwork when FATE tests are failing, > covering some possibly more useful information. > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v1 > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v1 > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20 > > libavutil/tests/md5.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c > index 42e4538e0a..1f27c40987 100644 > --- a/libavutil/tests/md5.c > +++ b/libavutil/tests/md5.c > @@ -33,8 +33,12 @@ int main(void) > { > uint8_t md5val[16]; > int i; > + > +#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 > volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > - // FIXME remove volatile once it has been fixed and all fate clients are updated I wonder if the volatile shouldn't just be removed after eight years. Carl Eugen
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Carl > Eugen Hoyos > Sent: Sunday, January 23, 2022 12:23 AM > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] libavutil/tests/md5: Avoid > warnings > > Am Fr., 21. Jan. 2022 um 02:18 Uhr schrieb softworkz > <ffmpegagent@gmail.com>: > > > > From: softworkz <softworkz@hotmail.com> > > > > Those are always showing up on Patchwork > > when FATE tests are failing, covering > > some possibly more useful information. > > > > Signed-off-by: softworkz <softworkz@hotmail.com> > > --- > > libavutil/tests/md5: Avoid warnings > > > > Those are always showing up on Patchwork when FATE tests are > failing, > > covering some possibly more useful information. > > > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr- > ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v1 > > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr- > ffstaging-20/softworkz/submit_md5-v1 > > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20 > > > > libavutil/tests/md5.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c > > index 42e4538e0a..1f27c40987 100644 > > --- a/libavutil/tests/md5.c > > +++ b/libavutil/tests/md5.c > > @@ -33,8 +33,12 @@ int main(void) > > { > > uint8_t md5val[16]; > > int i; > > + > > +#if defined(__clang__) && defined(__clang_major__) && > __clang_major__ < 4 > > volatile uint8_t in[1000]; // volatile to workaround > http://llvm.org/bugs/show_bug.cgi?id=20849 > > - // FIXME remove volatile once it has been fixed and all fate > clients are updated > > I wonder if the volatile shouldn't just be removed after eight years. > > Carl Eugen So, shall I submit another version that simply removes 'volatile'? softworkz
diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c index 42e4538e0a..1f27c40987 100644 --- a/libavutil/tests/md5.c +++ b/libavutil/tests/md5.c @@ -33,8 +33,12 @@ int main(void) { uint8_t md5val[16]; int i; + +#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 - // FIXME remove volatile once it has been fixed and all fate clients are updated +#else + uint8_t in[1000]; +#endif for (i = 0; i < 1000; i++) in[i] = i * i;