| Message ID | tencent_1EB2D5F20896E3840EB2FF6268185DC0D109@qq.com |
|---|---|
| State | Accepted |
| Commit | 341a483b0868d30d17bf8d5e82facb5e0944a6fe |
| Headers | show |
| Series | [FFmpeg-devel] avdevice/audiotoolbox: silence warning with new api | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Hi, Thilo: There is another patch that needs your review please. Thanks ------------------ Original ------------------ From: "FFmpeg development discussions and patches" <ffmpeg-devel@ffmpeg.org>; Date: Sat, Dec 9, 2023 08:50 PM To: "ffmpeg-devel"<ffmpeg-devel@ffmpeg.org>; Cc: "徐福隆"<839789740@qq.com>; Subject: [FFmpeg-devel] [PATCH] avdevice/audiotoolbox: silence warning with new api Building with macOS platform, the compiler has a warning: 'kAudioObjectPropertyElementMaster' is deprecated in macOS 12.0 Signed-off-by: xufuji456 <839789740@qq.com> --- libavdevice/audiotoolbox.m | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavdevice/audiotoolbox.m b/libavdevice/audiotoolbox.m index aa49e2c992..ae91a2bc62 100644 --- a/libavdevice/audiotoolbox.m +++ b/libavdevice/audiotoolbox.m @@ -85,7 +85,11 @@ static av_cold int at_write_header(AVFormatContext *avctx) AudioObjectPropertyAddress prop; prop.mSelector = kAudioHardwarePropertyDevices; prop.mScope = kAudioObjectPropertyScopeGlobal; +#if !TARGET_OS_IPHONE && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1200 + prop.mElement = kAudioObjectPropertyElementMain; +#else prop.mElement = kAudioObjectPropertyElementMaster; +#endif err = AudioObjectGetPropertyDataSize(kAudioObjectSystemObject, &prop, 0, NULL, &data_size); if (check_status(avctx, &err, "AudioObjectGetPropertyDataSize devices")) return AVERROR(EINVAL); -- 2.32.0 (Apple Git-132) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Am 11.12.23 um 16:28 schrieb 徐福隆 via ffmpeg-devel: > Hi, Thilo: > There is another patch that needs your review please. Thanks for pointing me to it. > --- > libavdevice/audiotoolbox.m | 4 ++++ > 1 file changed, 4 insertions(+) LGTM & pushed. Thanks, Thilo
diff --git a/libavdevice/audiotoolbox.m b/libavdevice/audiotoolbox.m index aa49e2c992..ae91a2bc62 100644 --- a/libavdevice/audiotoolbox.m +++ b/libavdevice/audiotoolbox.m @@ -85,7 +85,11 @@ static av_cold int at_write_header(AVFormatContext *avctx) AudioObjectPropertyAddress prop; prop.mSelector = kAudioHardwarePropertyDevices; prop.mScope = kAudioObjectPropertyScopeGlobal; +#if !TARGET_OS_IPHONE && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1200 + prop.mElement = kAudioObjectPropertyElementMain; +#else prop.mElement = kAudioObjectPropertyElementMaster; +#endif err = AudioObjectGetPropertyDataSize(kAudioObjectSystemObject, &prop, 0, NULL, &data_size); if (check_status(avctx, &err, "AudioObjectGetPropertyDataSize devices")) return AVERROR(EINVAL);
Building with macOS platform, the compiler has a warning: 'kAudioObjectPropertyElementMaster' is deprecated in macOS 12.0 Signed-off-by: xufuji456 <839789740@qq.com> --- libavdevice/audiotoolbox.m | 4 ++++ 1 file changed, 4 insertions(+)