diff mbox series

[FFmpeg-devel] avcodec/mediacodecenc: add profile names to options

Message ID tencent_8168467FFEAF023B89C021B790680203190A@qq.com
State Accepted
Commit fb85aa959aad113a2565e5ce97ed42a47583e698
Headers show
Series [FFmpeg-devel] avcodec/mediacodecenc: add profile names to options | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Zhao Zhili June 9, 2023, 11:14 a.m. UTC 
From: Zhao Zhili <zhilizhao@tencent.com>

H.264 high10/high422/high44 are unlikely supported by devices.
It's there for developers to do the experiment.

H.265 main10 works on my device with AV_PIX_FMT_MEDIACODEC.
OMX_COLOR_FormatYUV420Planar16 doesn't work.

Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
---
 libavcodec/mediacodecenc.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Comments

Tomas Härdin June 24, 2023, 9:16 a.m. UTC | #1 
fre 2023-06-09 klockan 19:14 +0800 skrev Zhao Zhili:
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> H.264 high10/high422/high44 are unlikely supported by devices.
> It's there for developers to do the experiment.
> 
> H.265 main10 works on my device with AV_PIX_FMT_MEDIACODEC.
> OMX_COLOR_FormatYUV420Planar16 doesn't work.

Looks reasonable enough. I guess we can never know beforehand which
profiles are supported anyway.

/Tomas
diff mbox series

Patch

diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c
index d23745c1c1..1da705d113 100644
--- a/libavcodec/mediacodecenc.c
+++ b/libavcodec/mediacodecenc.c
@@ -36,6 +36,7 @@ 
 #include "mediacodec.h"
 #include "mediacodec_wrapper.h"
 #include "mediacodecdec_common.h"
+#include "profiles.h"
 
 #define INPUT_DEQUEUE_TIMEOUT_US 8000
 #define OUTPUT_DEQUEUE_TIMEOUT_US 8000
@@ -658,6 +659,16 @@  enum MediaCodecAvcLevel {
 
 static const AVOption h264_options[] = {
     COMMON_OPTION
+
+    FF_AVCTX_PROFILE_OPTION("baseline",             NULL, VIDEO, FF_PROFILE_H264_BASELINE)
+    FF_AVCTX_PROFILE_OPTION("constrained_baseline", NULL, VIDEO, FF_PROFILE_H264_CONSTRAINED_BASELINE)
+    FF_AVCTX_PROFILE_OPTION("main",                 NULL, VIDEO, FF_PROFILE_H264_MAIN)
+    FF_AVCTX_PROFILE_OPTION("extended",             NULL, VIDEO, FF_PROFILE_H264_EXTENDED)
+    FF_AVCTX_PROFILE_OPTION("high",                 NULL, VIDEO, FF_PROFILE_H264_HIGH)
+    FF_AVCTX_PROFILE_OPTION("high10",               NULL, VIDEO, FF_PROFILE_H264_HIGH_10)
+    FF_AVCTX_PROFILE_OPTION("high422",              NULL, VIDEO, FF_PROFILE_H264_HIGH_422)
+    FF_AVCTX_PROFILE_OPTION("high444",              NULL, VIDEO, FF_PROFILE_H264_HIGH_444)
+
     { "level", "Specify level",
                 OFFSET(level), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "level" },
     { "1",      "", 0, AV_OPT_TYPE_CONST, { .i64 = AVCLevel1  },  0, 0, VE, "level" },
@@ -720,6 +731,10 @@  enum MediaCodecHevcLevel {
 
 static const AVOption hevc_options[] = {
     COMMON_OPTION
+
+    FF_AVCTX_PROFILE_OPTION("main",   NULL, VIDEO, FF_PROFILE_HEVC_MAIN)
+    FF_AVCTX_PROFILE_OPTION("main10", NULL, VIDEO, FF_PROFILE_HEVC_MAIN_10)
+
     { "level", "Specify tier and level",
                 OFFSET(level), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "level" },
     { "m1",    "Main tier level 1",
@@ -830,6 +845,12 @@  enum MediaCodecVP9Level {
 
 static const AVOption vp9_options[] = {
     COMMON_OPTION
+
+    FF_AVCTX_PROFILE_OPTION("profile0",   NULL, VIDEO, FF_PROFILE_VP9_0)
+    FF_AVCTX_PROFILE_OPTION("profile1",   NULL, VIDEO, FF_PROFILE_VP9_1)
+    FF_AVCTX_PROFILE_OPTION("profile2",   NULL, VIDEO, FF_PROFILE_VP9_2)
+    FF_AVCTX_PROFILE_OPTION("profile3",   NULL, VIDEO, FF_PROFILE_VP9_3)
+
     { "level", "Specify tier and level",
                 OFFSET(level), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "level" },
     { "1",     "Level 1",
@@ -884,6 +905,9 @@  enum MediaCodecMpeg4Level {
 
 static const AVOption mpeg4_options[] = {
     COMMON_OPTION
+
+    FF_MPEG4_PROFILE_OPTS
+
     { "level", "Specify tier and level",
                 OFFSET(level), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "level" },
     { "0",     "Level 0",
@@ -944,6 +968,9 @@  enum MediaCodecAV1Level {
 
 static const AVOption av1_options[] = {
     COMMON_OPTION
+
+    FF_AV1_PROFILE_OPTS
+
     { "level", "Specify tier and level",
                 OFFSET(level), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "level" },
     { "2",     "Level 2",