| Message ID | tencent_CA400B832623D08226E1E7D0AAB6D3125C06@qq.com |
|---|---|
| State | Accepted |
| Commit | a3ca4beeaa467bf10f2f4b9dc0e6cdbab68b9de4 |
| Headers | show |
| Series | [FFmpeg-devel] avcodec/evc: Remove redefine of HEVC_MAX_ENTRY_POINT_OFFSETS | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Thu, Feb 22, 2024 at 2:42 PM Zhao Zhili <quinkblack@foxmail.com> wrote: > > From: Zhao Zhili <zhilizhao@tencent.com> > > --- > libavcodec/evc.h | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/libavcodec/evc.h b/libavcodec/evc.h > index 9711c760fe..e493455a42 100644 > --- a/libavcodec/evc.h > +++ b/libavcodec/evc.h > @@ -141,15 +141,6 @@ enum { > > // A.4.1: table A.1 allows at most 600 slice segments for any level. > EVC_MAX_SLICE_SEGMENTS = 600, > - > - // 7.4.7.1: in the worst case (tiles_enabled_flag and > - // entropy_coding_sync_enabled_flag are both set), entry points can be > - // placed at the beginning of every Ctb row in every tile, giving an > - // upper bound of (num_tile_columns_minus1 + 1) * PicHeightInCtbsY - 1. > - // Only a stream with very high resolution and perverse parameters could > - // get near that, though, so set a lower limit here with the maximum > - // possible value for 4K video (at most 135 16x16 Ctb rows). > - HEVC_MAX_ENTRY_POINT_OFFSETS = EVC_MAX_TILE_COLUMNS * 135, > }; LGTM, thx
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Zhao > Zhili > Sent: czwartek, 22 lutego 2024 07:42 > To: ffmpeg-devel@ffmpeg.org > Cc: Zhao Zhili <zhilizhao@tencent.com> > Subject: [FFmpeg-devel] [PATCH] avcodec/evc: Remove redefine of > HEVC_MAX_ENTRY_POINT_OFFSETS > > From: Zhao Zhili <zhilizhao@tencent.com> > > --- > libavcodec/evc.h | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/libavcodec/evc.h b/libavcodec/evc.h index 9711c760fe..e493455a42 > 100644 > --- a/libavcodec/evc.h > +++ b/libavcodec/evc.h > @@ -141,15 +141,6 @@ enum { > > // A.4.1: table A.1 allows at most 600 slice segments for any level. > EVC_MAX_SLICE_SEGMENTS = 600, > - > - // 7.4.7.1: in the worst case (tiles_enabled_flag and > - // entropy_coding_sync_enabled_flag are both set), entry points can be > - // placed at the beginning of every Ctb row in every tile, giving an > - // upper bound of (num_tile_columns_minus1 + 1) * PicHeightInCtbsY - 1. > - // Only a stream with very high resolution and perverse parameters could > - // get near that, though, so set a lower limit here with the maximum > - // possible value for 4K video (at most 135 16x16 Ctb rows). > - HEVC_MAX_ENTRY_POINT_OFFSETS = EVC_MAX_TILE_COLUMNS * 135, I confirm, the definition and comment lines should be removed. Thank you for removing it. > }; > > #endif // AVCODEC_EVC_H > -- > 2.42.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://protect2.fireeye.com/v1/url?k=f0e40b7a-916f1e5a-f0e58035- > 74fe485fb347-2f46b0db54ce070f&q=1&e=7726f18d-7d3b-4f9e-99e9- > d37717d5f7c4&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp > eg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe".
diff --git a/libavcodec/evc.h b/libavcodec/evc.h index 9711c760fe..e493455a42 100644 --- a/libavcodec/evc.h +++ b/libavcodec/evc.h @@ -141,15 +141,6 @@ enum { // A.4.1: table A.1 allows at most 600 slice segments for any level. EVC_MAX_SLICE_SEGMENTS = 600, - - // 7.4.7.1: in the worst case (tiles_enabled_flag and - // entropy_coding_sync_enabled_flag are both set), entry points can be - // placed at the beginning of every Ctb row in every tile, giving an - // upper bound of (num_tile_columns_minus1 + 1) * PicHeightInCtbsY - 1. - // Only a stream with very high resolution and perverse parameters could - // get near that, though, so set a lower limit here with the maximum - // possible value for 4K video (at most 135 16x16 Ctb rows). - HEVC_MAX_ENTRY_POINT_OFFSETS = EVC_MAX_TILE_COLUMNS * 135, }; #endif // AVCODEC_EVC_H
From: Zhao Zhili <zhilizhao@tencent.com> --- libavcodec/evc.h | 9 --------- 1 file changed, 9 deletions(-)