| Message ID | tencent_D70EE0EA5B2635D9805A34393E8F56D59C09@qq.com |
|---|---|
| State | Accepted |
| Commit | eb96dda5ede46550af8a9fce77fea20a00838a83 |
| Headers | show |
| Series | [FFmpeg-devel,1/2] avdevice/android_camera: fix missing include for usleep | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Zhao Zhili: > From: Zhao Zhili <zhilizhao@tencent.com> > > Signed-off-by: Zhao Zhili <zhilizhao@tencent.com> > --- > libavdevice/android_camera.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavdevice/android_camera.c b/libavdevice/android_camera.c > index 1934999c18..0425b27518 100644 > --- a/libavdevice/android_camera.c > +++ b/libavdevice/android_camera.c > @@ -25,6 +25,7 @@ > #include <stdatomic.h> > #include <stdbool.h> > #include <stdint.h> > +#include <unistd.h> > > #include <camera/NdkCameraDevice.h> > #include <camera/NdkCameraManager.h> Sorry for having broken this in ee485b4051c24e2cebe46b426294b346f0f5fff4. When creating this patch, I just looked at what os_support.h directly provided (namely redefinitions of lseek and fstat etc.) and checked what files used any of this. I don't not check for indirect includes that are not redefined by os_support.h. (And honestly, if something relies on indirect includes, then that's the bug.) - Andreas
diff --git a/libavdevice/android_camera.c b/libavdevice/android_camera.c index 1934999c18..0425b27518 100644 --- a/libavdevice/android_camera.c +++ b/libavdevice/android_camera.c @@ -25,6 +25,7 @@ #include <stdatomic.h> #include <stdbool.h> #include <stdint.h> +#include <unistd.h> #include <camera/NdkCameraDevice.h> #include <camera/NdkCameraManager.h>