Message ID | tencent_DC330DA84953FB736D95C889032EA3A54C05@qq.com |
---|---|
State | Accepted |
Commit | be7ac511a6b4dd9883c0a6dd8323b04f651193f4 |
Headers | show |
Series | [FFmpeg-devel] avformat/mov: avss box should be AV_CODEC_ID_CAVS | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | success | Make finished |
yinshiyou/make_fate_loongarch64 | success | Make fate finished |
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
diff --git a/libavformat/mov.c b/libavformat/mov.c index 444aca5235..ac19b3157a 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1911,7 +1911,7 @@ static int mov_read_alac(MOVContext *c, AVIOContext *pb, MOVAtom atom) static int mov_read_avss(MOVContext *c, AVIOContext *pb, MOVAtom atom) { - return mov_read_extradata(c, pb, atom, AV_CODEC_ID_AVS); + return mov_read_extradata(c, pb, atom, AV_CODEC_ID_CAVS); } static int mov_read_jp2h(MOVContext *c, AVIOContext *pb, MOVAtom atom)
From: Zhao Zhili <zhilizhao@tencent.com> I cannot find the spec, but according to the original commit d4fdba0df71, it's CAVS. e571305a714 changed it to AVS by accident. Ten years on, nothing happened. We still have the sample [1], however, since there is no cavs_mp4tofoobar bsf, the cavs decoder doesn't work. I don't know if there is any use case. [1] https://samples.ffmpeg.org/AVS/AVSFileFormat/AVSFileFormat.mp4 --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)