| Message ID | CAB0OVGr7oNPoYDY-wvDv9Z_iM3+GDBRuOe_usGhr1m11+BVQ6g@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
2017-11-12 15:29 GMT+01:00 Carl Eugen Hoyos <ceffmpeg@gmail.com>: > Hi! > > Attached patch fixes a warning on aix here. Ping. Carl Eugen
On Sun, Nov 12, 2017 at 03:29:21PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a warning on aix here. > > Please comment, Carl Eugen > tcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > fa136707423e2f36ee2400c37c2d9fefb027fe80 0001-lavf-tcp-Fix-the-type-of-the-optlen-argument-to-gets.patch > From cd61d9b7b52fd6c74cb19a8e9383b3a2056e67b2 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos <ceffmpeg@gmail.com> > Date: Sun, 12 Nov 2017 15:23:14 +0100 > Subject: [PATCH] lavf/tcp: Fix the type of the optlen argument to > getsockopt(). > > Fixes a warning on aix: > libavformat/tcp.c:283:58: warning: passing argument 5 of 'getsockopt' from incompatible pointer type should be ok if you checked the type in the specs [...]
2017-11-18 3:24 GMT+01:00 Michael Niedermayer <michael@niedermayer.cc>: > On Sun, Nov 12, 2017 at 03:29:21PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes a warning on aix here. >> >> Please comment, Carl Eugen > >> tcp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> fa136707423e2f36ee2400c37c2d9fefb027fe80 0001-lavf-tcp-Fix-the-type-of-the-optlen-argument-to-gets.patch >> From cd61d9b7b52fd6c74cb19a8e9383b3a2056e67b2 Mon Sep 17 00:00:00 2001 >> From: Carl Eugen Hoyos <ceffmpeg@gmail.com> >> Date: Sun, 12 Nov 2017 15:23:14 +0100 >> Subject: [PATCH] lavf/tcp: Fix the type of the optlen argument to >> getsockopt(). >> >> Fixes a warning on aix: >> libavformat/tcp.c:283:58: warning: passing argument 5 of 'getsockopt' from incompatible pointer type > > should be ok if you checked the type in the specs The header is confirmed by the information on opengroup.org, so pushed. Thank you, Carl Eugen
From cd61d9b7b52fd6c74cb19a8e9383b3a2056e67b2 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos <ceffmpeg@gmail.com> Date: Sun, 12 Nov 2017 15:23:14 +0100 Subject: [PATCH] lavf/tcp: Fix the type of the optlen argument to getsockopt(). Fixes a warning on aix: libavformat/tcp.c:283:58: warning: passing argument 5 of 'getsockopt' from incompatible pointer type --- libavformat/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index 07b4ed9..dfb5e5b 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -270,7 +270,7 @@ static int tcp_get_window_size(URLContext *h) { TCPContext *s = h->priv_data; int avail; - int avail_len = sizeof(avail); + socklen_t avail_len = sizeof(avail); #if HAVE_WINSOCK2_H /* SO_RCVBUF with winsock only reports the actual TCP window size when -- 1.7.10.4