diff mbox

[FFmpeg-devel,1/2] avfilter/vf_*_vaapi: Add missing AV_OPT_FLAG_FILTERING_PARAM

Message ID 20180306144306.18665-1-michael@niedermayer.cc
State Accepted
Commit c87bf5b6d0cd662c8d68672262ea5f056640206a
Headers show

Commit Message

Michael Niedermayer March 6, 2018, 2:43 p.m. UTC
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavfilter/vf_misc_vaapi.c    | 2 +-
 libavfilter/vf_procamp_vaapi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Jun Zhao March 7, 2018, 12:08 a.m. UTC | #1
On 2018/3/6 22:43, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavfilter/vf_misc_vaapi.c    | 2 +-
>  libavfilter/vf_procamp_vaapi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/vf_misc_vaapi.c b/libavfilter/vf_misc_vaapi.c
> index 8b179fe215..30b808a993 100644
> --- a/libavfilter/vf_misc_vaapi.c
> +++ b/libavfilter/vf_misc_vaapi.c
> @@ -226,7 +226,7 @@ static av_cold int sharpness_vaapi_init(AVFilterContext *avctx)
>  }
>  
>  #define DOFFSET(x) offsetof(DenoiseVAAPIContext, x)
> -#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM)
> +#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_FILTERING_PARAM)
>  static const AVOption denoise_vaapi_options[] = {
>      { "denoise", "denoise level",
>        DOFFSET(denoise), AV_OPT_TYPE_INT, { .i64 = DENOISE_DEFAULT }, DENOISE_MIN, DENOISE_MAX, .flags = FLAGS },
> diff --git a/libavfilter/vf_procamp_vaapi.c b/libavfilter/vf_procamp_vaapi.c
> index 45a3120b23..10eccbe97d 100644
> --- a/libavfilter/vf_procamp_vaapi.c
> +++ b/libavfilter/vf_procamp_vaapi.c
> @@ -214,7 +214,7 @@ static av_cold int procamp_vaapi_init(AVFilterContext *avctx)
>  }
>  
>  #define OFFSET(x) offsetof(ProcampVAAPIContext, x)
> -#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM)
> +#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_FILTERING_PARAM)
>  static const AVOption procamp_vaapi_options[] = {
>      { "b", "Output video brightness",
>        OFFSET(bright),  AV_OPT_TYPE_FLOAT, { .dbl = BRIGHTNESS_DEFAULT }, BRIGHTNESS_MIN, BRIGHTNESS_MAX, .flags = FLAGS },
LGTM
Michael Niedermayer March 7, 2018, 1:03 a.m. UTC | #2
On Wed, Mar 07, 2018 at 08:08:52AM +0800, Jun Zhao wrote:
> 
> 
> On 2018/3/6 22:43, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavfilter/vf_misc_vaapi.c    | 2 +-
> >  libavfilter/vf_procamp_vaapi.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavfilter/vf_misc_vaapi.c b/libavfilter/vf_misc_vaapi.c
> > index 8b179fe215..30b808a993 100644
> > --- a/libavfilter/vf_misc_vaapi.c
> > +++ b/libavfilter/vf_misc_vaapi.c
> > @@ -226,7 +226,7 @@ static av_cold int sharpness_vaapi_init(AVFilterContext *avctx)
> >  }
> >  
> >  #define DOFFSET(x) offsetof(DenoiseVAAPIContext, x)
> > -#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM)
> > +#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_FILTERING_PARAM)
> >  static const AVOption denoise_vaapi_options[] = {
> >      { "denoise", "denoise level",
> >        DOFFSET(denoise), AV_OPT_TYPE_INT, { .i64 = DENOISE_DEFAULT }, DENOISE_MIN, DENOISE_MAX, .flags = FLAGS },
> > diff --git a/libavfilter/vf_procamp_vaapi.c b/libavfilter/vf_procamp_vaapi.c
> > index 45a3120b23..10eccbe97d 100644
> > --- a/libavfilter/vf_procamp_vaapi.c
> > +++ b/libavfilter/vf_procamp_vaapi.c
> > @@ -214,7 +214,7 @@ static av_cold int procamp_vaapi_init(AVFilterContext *avctx)
> >  }
> >  
> >  #define OFFSET(x) offsetof(ProcampVAAPIContext, x)
> > -#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM)
> > +#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_FILTERING_PARAM)
> >  static const AVOption procamp_vaapi_options[] = {
> >      { "b", "Output video brightness",
> >        OFFSET(bright),  AV_OPT_TYPE_FLOAT, { .dbl = BRIGHTNESS_DEFAULT }, BRIGHTNESS_MIN, BRIGHTNESS_MAX, .flags = FLAGS },
> LGTM

will apply

thx

[...]
diff mbox

Patch

diff --git a/libavfilter/vf_misc_vaapi.c b/libavfilter/vf_misc_vaapi.c
index 8b179fe215..30b808a993 100644
--- a/libavfilter/vf_misc_vaapi.c
+++ b/libavfilter/vf_misc_vaapi.c
@@ -226,7 +226,7 @@  static av_cold int sharpness_vaapi_init(AVFilterContext *avctx)
 }
 
 #define DOFFSET(x) offsetof(DenoiseVAAPIContext, x)
-#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM)
+#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_FILTERING_PARAM)
 static const AVOption denoise_vaapi_options[] = {
     { "denoise", "denoise level",
       DOFFSET(denoise), AV_OPT_TYPE_INT, { .i64 = DENOISE_DEFAULT }, DENOISE_MIN, DENOISE_MAX, .flags = FLAGS },
diff --git a/libavfilter/vf_procamp_vaapi.c b/libavfilter/vf_procamp_vaapi.c
index 45a3120b23..10eccbe97d 100644
--- a/libavfilter/vf_procamp_vaapi.c
+++ b/libavfilter/vf_procamp_vaapi.c
@@ -214,7 +214,7 @@  static av_cold int procamp_vaapi_init(AVFilterContext *avctx)
 }
 
 #define OFFSET(x) offsetof(ProcampVAAPIContext, x)
-#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM)
+#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_FILTERING_PARAM)
 static const AVOption procamp_vaapi_options[] = {
     { "b", "Output video brightness",
       OFFSET(bright),  AV_OPT_TYPE_FLOAT, { .dbl = BRIGHTNESS_DEFAULT }, BRIGHTNESS_MIN, BRIGHTNESS_MAX, .flags = FLAGS },