| Message ID | c59b527f-1374-8fee-2d4a-732ff950e5c3@gyani.pro |
|---|---|
| State | Accepted |
| Commit | 3b825b2f81e74bf9709d376f61fd1bf9a394f6ad |
| Headers | show |
On 10-12-2018 08:53 PM, Gyan wrote: > Maybe we should set a ffprobe variable in the fate Makefile, like done > for ffmpeg on ln 8. > > Gyan Will push tonight if no objections. Gyan
On 11-12-2018 02:18 PM, Gyan wrote: > > On 10-12-2018 08:53 PM, Gyan wrote: >> Maybe we should set a ffprobe variable in the fate Makefile, like >> done for ffmpeg on ln 8. >> >> Gyan > > Will push tonight if no objections. Pushed as 3b825b2f81e74bf9709d376f61fd1bf9a394f6ad Gyan
diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak index 4df0fe6490..8ed66cf135 100644 --- a/tests/fate/mov.mak +++ b/tests/fate/mov.mak @@ -123,4 +123,4 @@ fate-mov-faststart-4gb-overflow: CMD = run tools/qt-faststart$(EXESUF) $(TARGET_ fate-mov-faststart-4gb-overflow: CMP = oneline fate-mov-faststart-4gb-overflow: REF = bc875921f151871e787c4b4023269b29 -fate-mov-mp4-with-mov-in24-ver: CMD = run ffprobe -show_entries stream=codec_name -select_streams 1 $(TARGET_SAMPLES)/mov/mp4-with-mov-in24-ver.mp4 +fate-mov-mp4-with-mov-in24-ver: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream=codec_name -select_streams 1 $(TARGET_SAMPLES)/mov/mp4-with-mov-in24-ver.mp4
Maybe we should set a ffprobe variable in the fate Makefile, like done for ffmpeg on ln 8. Gyan From f1cdb3ee993602618bad243df07c0e33263cc211 Mon Sep 17 00:00:00 2001 From: Gyan Doshi <ffmpeg@gyani.pro> Date: Mon, 10 Dec 2018 20:44:33 +0530 Subject: [PATCH] fate: add prog suffix in fate-mov-mp4-with-mov-in24-ver Prevent test failure with builds that set a suffix and/or extension for the ffprobe binary --- tests/fate/mov.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)