diff mbox series

[FFmpeg-devel,V1,11/11] lavfi/vulume: enable runtime change flag

Message ID 1578716038-9645-11-git-send-email-mypopydev@gmail.com
State New
Headers
Series [FFmpeg-devel,V1,01/11] lavfi/spp: add "quality" option in runtime change path |

Checks

Context Check Description
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Jun Zhao Jan. 11, 2020, 4:13 a.m. UTC 
From: Jun Zhao <barryjzhao@tencent.com>

 enable runtime change flag.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavfilter/af_volume.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Michael Niedermayer Jan. 11, 2020, 6:44 p.m. UTC | #1 
On Sat, Jan 11, 2020 at 12:13:58PM +0800, Jun Zhao wrote:
> From: Jun Zhao <barryjzhao@tencent.com>
> 
>  enable runtime change flag.
> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavfilter/af_volume.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

typo in commit message (vulume)

[...]
Jun Zhao Jan. 13, 2020, 12:53 a.m. UTC | #2 
On Sun, Jan 12, 2020 at 2:44 AM Michael Niedermayer
<michael@niedermayer.cc> wrote:
>
> On Sat, Jan 11, 2020 at 12:13:58PM +0800, Jun Zhao wrote:
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> >  enable runtime change flag.
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >  libavfilter/af_volume.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
>
> typo in commit message (vulume)
>
Fixed in local
diff mbox series

Patch

diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c
index b106ed8..213c571 100644
--- a/libavfilter/af_volume.c
+++ b/libavfilter/af_volume.c
@@ -62,10 +62,11 @@  static const char *const var_names[] = {
 #define OFFSET(x) offsetof(VolumeContext, x)
 #define A AV_OPT_FLAG_AUDIO_PARAM
 #define F AV_OPT_FLAG_FILTERING_PARAM
+#define T AV_OPT_FLAG_RUNTIME_PARAM
 
 static const AVOption volume_options[] = {
     { "volume", "set volume adjustment expression",
-            OFFSET(volume_expr), AV_OPT_TYPE_STRING, { .str = "1.0" }, .flags = A|F },
+            OFFSET(volume_expr), AV_OPT_TYPE_STRING, { .str = "1.0" }, .flags = A|F|T },
     { "precision", "select mathematical precision",
             OFFSET(precision), AV_OPT_TYPE_INT, { .i64 = PRECISION_FLOAT }, PRECISION_FIXED, PRECISION_DOUBLE, A|F, "precision" },
         { "fixed",  "select 8-bit fixed-point",     0, AV_OPT_TYPE_CONST, { .i64 = PRECISION_FIXED  }, INT_MIN, INT_MAX, A|F, "precision" },