| Message ID | 20200217073758.13203-1-martin@martin.st |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] Escape braces in a regex, fixing warnings with newer perl | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | fail | Failed to apply patch |
On Mon, Feb 17, 2020 at 3:46 PM Martin Storsjö <martin@martin.st> wrote: > > Perl 5.28 warns about this, saying it will be fatal in Perl 5.32. > > Signed-off-by: Martin Storsjö <martin@martin.st> > --- > gas-preprocessor.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl > index b2a4bcc..e3805e0 100755 > --- a/gas-preprocessor.pl > +++ b/gas-preprocessor.pl > @@ -1102,7 +1102,7 @@ sub handle_serialized_line { > } > > # Convert "ld1 {v0.4h-v3.4h}" into "ld1 {v0.4h,v1.4h,v2.4h,v3.4h}" > - if ($line =~ /(?:ld|st)\d\s+({\s*v(\d+)\.(\d[bhsdBHSD])\s*-\s*v(\d+)\.(\d[bhsdBHSD])\s*})/) { > + if ($line =~ /(?:ld|st)\d\s+(\{\s*v(\d+)\.(\d[bhsdBHSD])\s*-\s*v(\d+)\.(\d[bhsdBHSD])\s*\})/) { > my $regspec = $1; > my $reg1 = $2; > my $layout1 = $3; > -- LGTM, verified
On Tue, 18 Feb 2020, mypopy@gmail.com wrote: > On Mon, Feb 17, 2020 at 3:46 PM Martin Storsjö <martin@martin.st> wrote: >> >> Perl 5.28 warns about this, saying it will be fatal in Perl 5.32. >> >> Signed-off-by: Martin Storsjö <martin@martin.st> >> --- >> gas-preprocessor.pl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl >> index b2a4bcc..e3805e0 100755 >> --- a/gas-preprocessor.pl >> +++ b/gas-preprocessor.pl >> @@ -1102,7 +1102,7 @@ sub handle_serialized_line { >> } >> >> # Convert "ld1 {v0.4h-v3.4h}" into "ld1 {v0.4h,v1.4h,v2.4h,v3.4h}" >> - if ($line =~ /(?:ld|st)\d\s+({\s*v(\d+)\.(\d[bhsdBHSD])\s*-\s*v(\d+)\.(\d[bhsdBHSD])\s*})/) { >> + if ($line =~ /(?:ld|st)\d\s+(\{\s*v(\d+)\.(\d[bhsdBHSD])\s*-\s*v(\d+)\.(\d[bhsdBHSD])\s*\})/) { >> my $regspec = $1; >> my $reg1 = $2; >> my $layout1 = $3; >> -- > LGTM, verified Thanks, pushed. // Martin
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index b2a4bcc..e3805e0 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -1102,7 +1102,7 @@ sub handle_serialized_line { } # Convert "ld1 {v0.4h-v3.4h}" into "ld1 {v0.4h,v1.4h,v2.4h,v3.4h}" - if ($line =~ /(?:ld|st)\d\s+({\s*v(\d+)\.(\d[bhsdBHSD])\s*-\s*v(\d+)\.(\d[bhsdBHSD])\s*})/) { + if ($line =~ /(?:ld|st)\d\s+(\{\s*v(\d+)\.(\d[bhsdBHSD])\s*-\s*v(\d+)\.(\d[bhsdBHSD])\s*\})/) { my $regspec = $1; my $reg1 = $2; my $layout1 = $3;
Perl 5.28 warns about this, saying it will be fatal in Perl 5.32. Signed-off-by: Martin Storsjö <martin@martin.st> --- gas-preprocessor.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)