| Message ID | 1586612703-6862-2-git-send-email-mypopydev@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Support Dolby Vision | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
Am Sa., 11. Apr. 2020 um 15:53 Uhr schrieb Jun Zhao <mypopydev@gmail.com>: > > From: Jun Zhao <barryjzhao@tencent.com> > > add a new sidedata type for Dolby Vision. > > Signed-off-by: Jun Zhao <barryjzhao@tencent.com> > --- > libavcodec/avpacket.c | 1 + > libavcodec/packet.h | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > index ad020ee..276beeb 100644 > --- a/libavcodec/avpacket.c > +++ b/libavcodec/avpacket.c > @@ -396,6 +396,7 @@ const char *av_packet_side_data_name(enum AVPacketSideDataType type) > case AV_PKT_DATA_ENCRYPTION_INFO: return "Encryption info"; > case AV_PKT_DATA_AFD: return "Active Format Description data"; > case AV_PKT_DATA_ICC_PROFILE: return "ICC Profile"; > + case AV_PKT_DATA_DOLBY_VISION_DECODER_CONF: return "Dolby Vision"; Should be AV_PKT_DATA_DVISION_DECODER_CONF or similar to be on the safe side where it really doesn't matter to change it now. Carl Eugen
On Sat, Apr 11, 2020 at 10:55 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > > Am Sa., 11. Apr. 2020 um 15:53 Uhr schrieb Jun Zhao <mypopydev@gmail.com>: > > > > From: Jun Zhao <barryjzhao@tencent.com> > > > > add a new sidedata type for Dolby Vision. > > > > Signed-off-by: Jun Zhao <barryjzhao@tencent.com> > > --- > > libavcodec/avpacket.c | 1 + > > libavcodec/packet.h | 9 +++++++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > > index ad020ee..276beeb 100644 > > --- a/libavcodec/avpacket.c > > +++ b/libavcodec/avpacket.c > > @@ -396,6 +396,7 @@ const char *av_packet_side_data_name(enum AVPacketSideDataType type) > > case AV_PKT_DATA_ENCRYPTION_INFO: return "Encryption info"; > > case AV_PKT_DATA_AFD: return "Active Format Description data"; > > case AV_PKT_DATA_ICC_PROFILE: return "ICC Profile"; > > > + case AV_PKT_DATA_DOLBY_VISION_DECODER_CONF: return "Dolby Vision"; > > Should be AV_PKT_DATA_DVISION_DECODER_CONF or similar to be on the safe side > where it really doesn't matter to change it now. > It's ok to change the name, and wait more comments
diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index ad020ee..276beeb 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -396,6 +396,7 @@ const char *av_packet_side_data_name(enum AVPacketSideDataType type) case AV_PKT_DATA_ENCRYPTION_INFO: return "Encryption info"; case AV_PKT_DATA_AFD: return "Active Format Description data"; case AV_PKT_DATA_ICC_PROFILE: return "ICC Profile"; + case AV_PKT_DATA_DOLBY_VISION_DECODER_CONF: return "Dolby Vision"; } return NULL; } diff --git a/libavcodec/packet.h b/libavcodec/packet.h index e53abe6..2f7b193 100644 --- a/libavcodec/packet.h +++ b/libavcodec/packet.h @@ -274,6 +274,15 @@ enum AVPacketSideDataType { AV_PKT_DATA_ICC_PROFILE, /** + * Dobly vision decoder configuration + * ref: + * dolby-vision-bitstreams-within-the-iso-base-media-file-format-v2.1.2, section 2.2 + * dolby-vision-bitstreams-in-mpeg-2-transport-stream-multiplex-v1.2, section 3.3 + * Tags are stored in struct AVDOVIDecoderConfigurationRecord. + */ + AV_PKT_DATA_DOLBY_VISION_DECODER_CONF, + + /** * The number of side data types. * This is not part of the public API/ABI in the sense that it may * change when new side data types are added.