diff mbox series

[FFmpeg-devel,4/5] avformat/mpegts: fix av_freep for dovi pointer

Message ID 1588251554-3665-4-git-send-email-lance.lmwang@gmail.com
State Superseded
Headers show
Series [FFmpeg-devel,1/5] avcodec/v4l2_m2m_enc: reindent code | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Lance Wang April 30, 2020, 12:59 p.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavformat/mpegts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Rheinhardt April 30, 2020, 1:11 p.m. UTC | #1 
lance.lmwang@gmail.com:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavformat/mpegts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
> index ff3898c3a5..3bd98e5743 100644
> --- a/libavformat/mpegts.c
> +++ b/libavformat/mpegts.c
> @@ -2180,7 +2180,7 @@ int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type
>              ret = av_stream_add_side_data(st, AV_PKT_DATA_DOVI_CONF,
>                                            (uint8_t *)dovi, dovi_size);
>              if (ret < 0) {
> -                av_freep(dovi);
> +                av_freep(&dovi);
>                  return ret;
>              }
>  
> 
LGTM. Same remark as for patch 3.

- Andreas
diff mbox series

Patch

diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index ff3898c3a5..3bd98e5743 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -2180,7 +2180,7 @@  int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type
             ret = av_stream_add_side_data(st, AV_PKT_DATA_DOVI_CONF,
                                           (uint8_t *)dovi, dovi_size);
             if (ret < 0) {
-                av_freep(dovi);
+                av_freep(&dovi);
                 return ret;
             }