diff mbox series

[FFmpeg-devel,v2,4/5] avformat/mpegts: fix av_freep for dovi pointer

Message ID 1588252828-4534-1-git-send-email-lance.lmwang@gmail.com
State Accepted
Commit 9dd2587f60015a211f3120233e44e829ffd66c6f
Headers show
Series None | expand

Commit Message

Lance Wang April 30, 2020, 1:20 p.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavformat/mpegts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Rheinhardt April 30, 2020, 1:44 p.m. UTC | #1 
lance.lmwang@gmail.com:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavformat/mpegts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
> index ff3898c..0833d62 100644
> --- a/libavformat/mpegts.c
> +++ b/libavformat/mpegts.c
> @@ -2180,7 +2180,7 @@ int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type
>              ret = av_stream_add_side_data(st, AV_PKT_DATA_DOVI_CONF,
>                                            (uint8_t *)dovi, dovi_size);
>              if (ret < 0) {
> -                av_freep(dovi);
> +                av_free(dovi);
>                  return ret;
>              }
>  
> 
LGTM.

- Andreas
mypopy@gmail.com May 1, 2020, 4:30 a.m. UTC | #2 
On Thu, Apr 30, 2020 at 9:44 PM Andreas Rheinhardt
<andreas.rheinhardt@gmail.com> wrote:
>
> lance.lmwang@gmail.com:
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  libavformat/mpegts.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
> > index ff3898c..0833d62 100644
> > --- a/libavformat/mpegts.c
> > +++ b/libavformat/mpegts.c
> > @@ -2180,7 +2180,7 @@ int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type
> >              ret = av_stream_add_side_data(st, AV_PKT_DATA_DOVI_CONF,
> >                                            (uint8_t *)dovi, dovi_size);
> >              if (ret < 0) {
> > -                av_freep(dovi);
> > +                av_free(dovi);
> >                  return ret;
> >              }
> >
> >
> LGTM.
>
> - Andreas
Patchset v2 3-4 applied, tks
diff mbox series

Patch

diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index ff3898c..0833d62 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -2180,7 +2180,7 @@  int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type
             ret = av_stream_add_side_data(st, AV_PKT_DATA_DOVI_CONF,
                                           (uint8_t *)dovi, dovi_size);
             if (ret < 0) {
-                av_freep(dovi);
+                av_free(dovi);
                 return ret;
             }