diff mbox series

[FFmpeg-devel,2/2] lavf/hls: add AC-3/EAC-3 to allowed extensions file list

Message ID 1601036351-25991-2-git-send-email-mypopydev@gmail.com
State Accepted
Commit 5bf22519cec50cceada06bb58a9d1fa2bb30d1ec
Headers show
Series [FFmpeg-devel,1/2] examples/muxing: misc style fixes | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Jun Zhao Sept. 25, 2020, 12:19 p.m. UTC 
From: Jun Zhao <barryjzhao@tencent.com>

Add AC-3/EAC-3 to allowed extensions file list.

From HTTP Live Streaming 2nd Edition draft-pantos-hls-rfc8216bis-07
section 3.1.3.Packed Audio, HLS demuxer need to support MP3/AC-3/EAC-3.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavformat/hls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Steven Liu Sept. 26, 2020, 8:39 a.m. UTC | #1 
Jun Zhao <mypopydev@gmail.com> 于2020年9月25日周五 下午8:25写道：
>
> From: Jun Zhao <barryjzhao@tencent.com>
>
> Add AC-3/EAC-3 to allowed extensions file list.
>
> From HTTP Live Streaming 2nd Edition draft-pantos-hls-rfc8216bis-07
> section 3.1.3.Packed Audio, HLS demuxer need to support MP3/AC-3/EAC-3.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavformat/hls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index f33ff3f..72e28ab 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -2371,7 +2371,7 @@ static const AVOption hls_options[] = {
>          OFFSET(live_start_index), AV_OPT_TYPE_INT, {.i64 = -3}, INT_MIN, INT_MAX, FLAGS},
>      {"allowed_extensions", "List of file extensions that hls is allowed to access",
>          OFFSET(allowed_extensions), AV_OPT_TYPE_STRING,
> -        {.str = "3gp,aac,avi,flac,mkv,m3u8,m4a,m4s,m4v,mpg,mov,mp2,mp3,mp4,mpeg,mpegts,ogg,ogv,oga,ts,vob,wav"},
> +        {.str = "3gp,aac,avi,ac3,eac3,flac,mkv,m3u8,m4a,m4s,m4v,mpg,mov,mp2,mp3,mp4,mpeg,mpegts,ogg,ogv,oga,ts,vob,wav"},
>          INT_MIN, INT_MAX, FLAGS},
>      {"max_reload", "Maximum number of times a insufficient list is attempted to be reloaded",
>          OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX, FLAGS},
> --
> 2.7.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

LGTM


Thanks

Steven
mypopy@gmail.com Sept. 28, 2020, 1:31 a.m. UTC | #2 
On Sat, Sep 26, 2020 at 4:47 PM Steven Liu <lingjiujianke@gmail.com> wrote:
>
> Jun Zhao <mypopydev@gmail.com> 于2020年9月25日周五 下午8:25写道：
> >
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > Add AC-3/EAC-3 to allowed extensions file list.
> >
> > From HTTP Live Streaming 2nd Edition draft-pantos-hls-rfc8216bis-07
> > section 3.1.3.Packed Audio, HLS demuxer need to support MP3/AC-3/EAC-3.
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >  libavformat/hls.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/hls.c b/libavformat/hls.c
> > index f33ff3f..72e28ab 100644
> > --- a/libavformat/hls.c
> > +++ b/libavformat/hls.c
> > @@ -2371,7 +2371,7 @@ static const AVOption hls_options[] = {
> >          OFFSET(live_start_index), AV_OPT_TYPE_INT, {.i64 = -3}, INT_MIN, INT_MAX, FLAGS},
> >      {"allowed_extensions", "List of file extensions that hls is allowed to access",
> >          OFFSET(allowed_extensions), AV_OPT_TYPE_STRING,
> > -        {.str = "3gp,aac,avi,flac,mkv,m3u8,m4a,m4s,m4v,mpg,mov,mp2,mp3,mp4,mpeg,mpegts,ogg,ogv,oga,ts,vob,wav"},
> > +        {.str = "3gp,aac,avi,ac3,eac3,flac,mkv,m3u8,m4a,m4s,m4v,mpg,mov,mp2,mp3,mp4,mpeg,mpegts,ogg,ogv,oga,ts,vob,wav"},
> >          INT_MIN, INT_MAX, FLAGS},
> >      {"max_reload", "Maximum number of times a insufficient list is attempted to be reloaded",
> >          OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX, FLAGS},
> > --
> > 2.7.4
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> LGTM
>
>

patchset pushed, thx
diff mbox series

Patch

diff --git a/libavformat/hls.c b/libavformat/hls.c
index f33ff3f..72e28ab 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -2371,7 +2371,7 @@  static const AVOption hls_options[] = {
         OFFSET(live_start_index), AV_OPT_TYPE_INT, {.i64 = -3}, INT_MIN, INT_MAX, FLAGS},
     {"allowed_extensions", "List of file extensions that hls is allowed to access",
         OFFSET(allowed_extensions), AV_OPT_TYPE_STRING,
-        {.str = "3gp,aac,avi,flac,mkv,m3u8,m4a,m4s,m4v,mpg,mov,mp2,mp3,mp4,mpeg,mpegts,ogg,ogv,oga,ts,vob,wav"},
+        {.str = "3gp,aac,avi,ac3,eac3,flac,mkv,m3u8,m4a,m4s,m4v,mpg,mov,mp2,mp3,mp4,mpeg,mpegts,ogg,ogv,oga,ts,vob,wav"},
         INT_MIN, INT_MAX, FLAGS},
     {"max_reload", "Maximum number of times a insufficient list is attempted to be reloaded",
         OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX, FLAGS},