diff mbox series

[FFmpeg-devel,6/6] tools/target_dec_fuzzer: remove calls to avcodec_register*()

Message ID 20201010034617.21922-1-jamrial@gmail.com
State Accepted
Commit 3e4214109a1ef394af8cc92064deff254989bf09
Headers show
Series [FFmpeg-devel,1/3] avdevice/alldevices: stop using deprecated linked list API | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make warning Make failed

Commit Message

James Almer Oct. 10, 2020, 3:46 a.m. UTC 
They are no-ops.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 tools/target_dec_fuzzer.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Anton Khirnov Oct. 19, 2020, 2:59 p.m. UTC | #1 
Quoting James Almer (2020-10-10 05:46:17)
> They are no-ops.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  tools/target_dec_fuzzer.c | 3 ---
>  1 file changed, 3 deletions(-)

Not exactly no-ops yet, but looks ok anyway.
James Almer Oct. 19, 2020, 3:06 p.m. UTC | #2 
On 10/19/2020 11:59 AM, Anton Khirnov wrote:
> Quoting James Almer (2020-10-10 05:46:17)
>> They are no-ops.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  tools/target_dec_fuzzer.c | 3 ---
>>  1 file changed, 3 deletions(-)
> 
> Not exactly no-ops yet, but looks ok anyway.

Yeah, i wrote that comment thinking about their effect in this tool,
since nothing needs the AVCodec->next pointers initialized.

I'll remove it and apply patches 1, 4, 5 and 6. Thanks.
diff mbox series

Patch

diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c
index 7bea736fcf..39d4bb5647 100644
--- a/tools/target_dec_fuzzer.c
+++ b/tools/target_dec_fuzzer.c
@@ -118,17 +118,14 @@  int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
 #define DECODER_SYMBOL(CODEC) DECODER_SYMBOL0(CODEC)
         extern AVCodec DECODER_SYMBOL(FFMPEG_DECODER);
         codec_list[0] = &DECODER_SYMBOL(FFMPEG_DECODER);
-        avcodec_register(&DECODER_SYMBOL(FFMPEG_DECODER));
 
 #if FFMPEG_DECODER == tiff || FFMPEG_DECODER == tdsc
         extern AVCodec DECODER_SYMBOL(mjpeg);
         codec_list[1] = &DECODER_SYMBOL(mjpeg);
-        avcodec_register(&DECODER_SYMBOL(mjpeg));
 #endif
 
         c = &DECODER_SYMBOL(FFMPEG_DECODER);
 #else
-        avcodec_register_all();
         c = AVCodecInitialize(FFMPEG_CODEC);  // Done once.
 #endif
         av_log_set_level(AV_LOG_PANIC);