diff mbox series

[FFmpeg-devel] avfilter/vf_hwupload_cuda: add transparent pix_fmts

Message ID 20201203155603.722243-1-raniz@raneland.se
State New
Headers show
Series [FFmpeg-devel] avfilter/vf_hwupload_cuda: add transparent pix_fmts | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Daniel Raniz Raneland Dec. 3, 2020, 3:56 p.m. UTC 
Signed-off-by: Daniel Raniz Raneland <raniz@raneland.se>
---
 libavfilter/vf_hwupload_cuda.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Timo Rothenpieler Dec. 4, 2020, 1:56 p.m. UTC | #1 
On 03.12.2020 16:56, Daniel Raniz Raneland wrote:
> Signed-off-by: Daniel Raniz Raneland <raniz@raneland.se>
> ---
>   libavfilter/vf_hwupload_cuda.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavfilter/vf_hwupload_cuda.c b/libavfilter/vf_hwupload_cuda.c
> index 33906f2515..83b7babeaa 100644
> --- a/libavfilter/vf_hwupload_cuda.c
> +++ b/libavfilter/vf_hwupload_cuda.c
> @@ -60,6 +60,7 @@ static int cudaupload_query_formats(AVFilterContext *ctx)
>           AV_PIX_FMT_NV12, AV_PIX_FMT_YUV420P, AV_PIX_FMT_YUV444P,
>           AV_PIX_FMT_P010, AV_PIX_FMT_P016, AV_PIX_FMT_YUV444P16,
>           AV_PIX_FMT_0RGB32, AV_PIX_FMT_0BGR32,
> +        AV_PIX_FMT_YUVA420P, AV_PIX_FMT_YUVA444P,
>   #if CONFIG_VULKAN
>           AV_PIX_FMT_VULKAN,
>   #endif
> 

AV_PIX_FMT_YUVA444P is not supported by the CUDA hwcontext.
AV_PIX_FMT_YUVA420P however is.
Daniel Raniz Raneland Dec. 6, 2020, 12:46 p.m. UTC | #2 
Oh, I just assumed it would work since YUVA420P worked out of the box
and both YUV420P and YUV444P were on the list of supported formats.

Removing then since I only need YUVA420P.
diff mbox series

Patch

diff --git a/libavfilter/vf_hwupload_cuda.c b/libavfilter/vf_hwupload_cuda.c
index 33906f2515..83b7babeaa 100644
--- a/libavfilter/vf_hwupload_cuda.c
+++ b/libavfilter/vf_hwupload_cuda.c
@@ -60,6 +60,7 @@  static int cudaupload_query_formats(AVFilterContext *ctx)
         AV_PIX_FMT_NV12, AV_PIX_FMT_YUV420P, AV_PIX_FMT_YUV444P,
         AV_PIX_FMT_P010, AV_PIX_FMT_P016, AV_PIX_FMT_YUV444P16,
         AV_PIX_FMT_0RGB32, AV_PIX_FMT_0BGR32,
+        AV_PIX_FMT_YUVA420P, AV_PIX_FMT_YUVA444P,
 #if CONFIG_VULKAN
         AV_PIX_FMT_VULKAN,
 #endif