diff mbox series

[FFmpeg-devel] fate: fix fate-filter-hqx on BE arches

Message ID 20201205022611.549778-1-andriy.gelman@gmail.com
State Accepted
Commit 5148740e79ec9c20a03365c03862d391981ace6b
Headers show
Series [FFmpeg-devel] fate: fix fate-filter-hqx on BE arches | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andriy Gelman Dec. 5, 2020, 2:26 a.m. UTC
From: Andriy Gelman <andriy.gelman@gmail.com>

One of the inputs to the fate test has an rgba pixel format which needs
to be converted to rgb32 (argb on BE) for the hqx filter. Because auto
scaling in the fate test is disabled, this needs a separate scale
filter.

Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
---
 tests/fate/filter-video.mak | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Michael Niedermayer Dec. 5, 2020, 10:51 p.m. UTC | #1
On Fri, Dec 04, 2020 at 09:26:11PM -0500, Andriy Gelman wrote:
> From: Andriy Gelman <andriy.gelman@gmail.com>
> 
> One of the inputs to the fate test has an rgba pixel format which needs
> to be converted to rgb32 (argb on BE) for the hqx filter. Because auto
> scaling in the fate test is disabled, this needs a separate scale
> filter.
> 
> Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
> ---
>  tests/fate/filter-video.mak | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

probably ok (cant test on MIPS atm)

thanks

[...]
Andriy Gelman Dec. 12, 2020, 10:38 p.m. UTC | #2
On Sat, 05. Dec 23:51, Michael Niedermayer wrote:
> On Fri, Dec 04, 2020 at 09:26:11PM -0500, Andriy Gelman wrote:
> > From: Andriy Gelman <andriy.gelman@gmail.com>
> > 
> > One of the inputs to the fate test has an rgba pixel format which needs
> > to be converted to rgb32 (argb on BE) for the hqx filter. Because auto
> > scaling in the fate test is disabled, this needs a separate scale
> > filter.
> > 
> > Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
> > ---
> >  tests/fate/filter-video.mak | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> probably ok (cant test on MIPS atm)
> 

will apply and enable the tests on patchwork.

--
Andriy
diff mbox series

Patch

diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index f9059f42f8..a2967de3ae 100644
--- a/tests/fate/filter-video.mak
+++ b/tests/fate/filter-video.mak
@@ -423,9 +423,9 @@  fate-filter-overlay-dvdsub-2397: CMD = framecrc -auto_conversion_filters -flags
 
 FATE_FILTER_HQX-$(call ALLYES, IMAGE2_DEMUXER PNG_DECODER HQX_FILTER) = fate-filter-hq2x fate-filter-hq3x fate-filter-hq4x
 FATE_FILTER_SAMPLES-yes += $(FATE_FILTER_HQX-yes)
-fate-filter-hq2x: CMD = framecrc -i $(TARGET_SAMPLES)/filter/pixelart%d.png -vf scale,hqx=2 -pix_fmt bgra
-fate-filter-hq3x: CMD = framecrc -i $(TARGET_SAMPLES)/filter/pixelart%d.png -vf scale,hqx=3 -pix_fmt bgra
-fate-filter-hq4x: CMD = framecrc -i $(TARGET_SAMPLES)/filter/pixelart%d.png -vf scale,hqx=4 -pix_fmt bgra
+fate-filter-hq2x: CMD = framecrc -i $(TARGET_SAMPLES)/filter/pixelart%d.png -vf scale,format=rgb32,hqx=2,scale,format=bgra
+fate-filter-hq3x: CMD = framecrc -i $(TARGET_SAMPLES)/filter/pixelart%d.png -vf scale,format=rgb32,hqx=3,scale,format=bgra
+fate-filter-hq4x: CMD = framecrc -i $(TARGET_SAMPLES)/filter/pixelart%d.png -vf scale,format=rgb32,hqx=4,scale,format=bgra
 fate-filter-hqx: $(FATE_FILTER_HQX-yes)
 
 FATE_FILTER_XBR-$(call ALLYES, IMAGE2_DEMUXER PNG_DECODER XBR_FILTER) = fate-filter-2xbr fate-filter-3xbr fate-filter-4xbr