mbox series

[FFmpeg-devel,0/4] avcodec Loongson-2 MMI fixes

Message ID 20210219052834.533558-1-jiaxun.yang@flygoat.com
Headers show
Series avcodec Loongson-2 MMI fixes | expand

Message

Jiaxun Yang Feb. 19, 2021, 5:28 a.m. UTC
Get MMI optimizations build for Loongson-2 again.
Tested on Loongson-2 and Loongson-3A.

Jiaxun Yang (4):
  avutil/mips: Use MMI_{L,S}QC1 macro in {SAVE,RECOVER}_REG
  avutil/mips: Extract load store with shift C1 pair marco
  avcodec/mips: Use MMI marcos to replace Loongson3 instructions
  avutil/mips: Use $at as MMI macro temporary register

 libavcodec/mips/h264chroma_mmi.c  |  26 +++-
 libavcodec/mips/h264dsp_mmi.c     |   8 +-
 libavcodec/mips/hevcdsp_mmi.c     | 251 ++++++++++++------------------
 libavcodec/mips/hpeldsp_mmi.c     |   1 +
 libavcodec/mips/simple_idct_mmi.c |  49 +++---
 libavcodec/mips/vp3dsp_idct_mmi.c |  11 +-
 libavcodec/mips/vp8dsp_mmi.c      | 100 +++++-------
 libavcodec/mips/vp9_mc_mmi.c      | 128 ++++++---------
 libavutil/mips/mmiutils.h         | 174 +++++++++++++--------
 9 files changed, 350 insertions(+), 398 deletions(-)

Comments

Shiyou Yin Feb. 23, 2021, 6:47 a.m. UTC | #1
> 2021年2月19日 下午1:28,Jiaxun Yang <jiaxun.yang@flygoat.com> 写道:
> 
> Get MMI optimizations build for Loongson-2 again.
> Tested on Loongson-2 and Loongson-3A.
> 
> Jiaxun Yang (4):
>  avutil/mips: Use MMI_{L,S}QC1 macro in {SAVE,RECOVER}_REG
>  avutil/mips: Extract load store with shift C1 pair marco
>  avcodec/mips: Use MMI marcos to replace Loongson3 instructions
>  avutil/mips: Use $at as MMI macro temporary register
> 
> libavcodec/mips/h264chroma_mmi.c  |  26 +++-
> libavcodec/mips/h264dsp_mmi.c     |   8 +-
> libavcodec/mips/hevcdsp_mmi.c     | 251 ++++++++++++------------------
> libavcodec/mips/hpeldsp_mmi.c     |   1 +
> libavcodec/mips/simple_idct_mmi.c |  49 +++---
> libavcodec/mips/vp3dsp_idct_mmi.c |  11 +-
> libavcodec/mips/vp8dsp_mmi.c      | 100 +++++-------
> libavcodec/mips/vp9_mc_mmi.c      | 128 ++++++---------
> libavutil/mips/mmiutils.h         | 174 +++++++++++++--------
> 9 files changed, 350 insertions(+), 398 deletions(-)
> 
> -- 
> 2.30.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”.

It's better to merge first three patches into one, otherwise the first two patches will cause build error.
Jiaxun Yang Feb. 24, 2021, 2:24 p.m. UTC | #2
On Tue, Feb 23, 2021, at 2:47 PM, 殷时友 wrote:
> 
> > 2021年2月19日 下午1:28,Jiaxun Yang <jiaxun.yang@flygoat.com> 写道:
> > 
> > Get MMI optimizations build for Loongson-2 again.
> > Tested on Loongson-2 and Loongson-3A.
> > 
> > Jiaxun Yang (4):
> >  avutil/mips: Use MMI_{L,S}QC1 macro in {SAVE,RECOVER}_REG
> >  avutil/mips: Extract load store with shift C1 pair marco
> >  avcodec/mips: Use MMI marcos to replace Loongson3 instructions
> >  avutil/mips: Use $at as MMI macro temporary register
> > 
> > libavcodec/mips/h264chroma_mmi.c  |  26 +++-
> > libavcodec/mips/h264dsp_mmi.c     |   8 +-
> > libavcodec/mips/hevcdsp_mmi.c     | 251 ++++++++++++------------------
> > libavcodec/mips/hpeldsp_mmi.c     |   1 +
> > libavcodec/mips/simple_idct_mmi.c |  49 +++---
> > libavcodec/mips/vp3dsp_idct_mmi.c |  11 +-
> > libavcodec/mips/vp8dsp_mmi.c      | 100 +++++-------
> > libavcodec/mips/vp9_mc_mmi.c      | 128 ++++++---------
> > libavutil/mips/mmiutils.h         | 174 +++++++++++++--------
> > 9 files changed, 350 insertions(+), 398 deletions(-)
> > 
> > -- 
> > 2.30.1
> > 
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > 
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”.
> 
> It's better to merge first three patches into one, otherwise the first 
> two patches will cause build error.

Thanks for your comments. I was thinking about make my changes clear but ability of bisect is important as well.

Will send v2 later.

- Jiaxun

> 
> 
>
Jiaxun Yang March 5, 2021, 2:16 a.m. UTC | #3
在 2021/2/23 下午2:47, 殷时友 写道:
> 
>> 2021年2月19日 下午1:28,Jiaxun Yang <jiaxun.yang@flygoat.com> 写道:
>>
>> Get MMI optimizations build for Loongson-2 again.
>> Tested on Loongson-2 and Loongson-3A.
>>
>> Jiaxun Yang (4):
>>   avutil/mips: Use MMI_{L,S}QC1 macro in {SAVE,RECOVER}_REG
>>   avutil/mips: Extract load store with shift C1 pair marco
>>   avcodec/mips: Use MMI marcos to replace Loongson3 instructions
>>   avutil/mips: Use $at as MMI macro temporary register
>>
>> libavcodec/mips/h264chroma_mmi.c  |  26 +++-
>> libavcodec/mips/h264dsp_mmi.c     |   8 +-
>> libavcodec/mips/hevcdsp_mmi.c     | 251 ++++++++++++------------------
>> libavcodec/mips/hpeldsp_mmi.c     |   1 +
>> libavcodec/mips/simple_idct_mmi.c |  49 +++---
>> libavcodec/mips/vp3dsp_idct_mmi.c |  11 +-
>> libavcodec/mips/vp8dsp_mmi.c      | 100 +++++-------
>> libavcodec/mips/vp9_mc_mmi.c      | 128 ++++++---------
>> libavutil/mips/mmiutils.h         | 174 +++++++++++++--------
>> 9 files changed, 350 insertions(+), 398 deletions(-)
>>
>> -- 
>> 2.30.1
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”.
> 
> It's better to merge first three patches into one, otherwise the first two patches will cause build error.

Just tried that first two patch won't break the build.
So I'd prefer commit as-is for bisect ability consideration.

Do you have other comments?

Thanks.

- Jiaxun

> 
>