diff mbox series

[FFmpeg-devel,v1,1/3] libavformat/rtsp.h : Add member ignore_rtcp to RTSPState

Message ID 20210417165528.79321-1-sunml@epoint.com.cn
State New, archived
Headers show
Series [FFmpeg-devel,v1,1/3] libavformat/rtsp.h : Add member ignore_rtcp to RTSPState | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

minlei sun April 17, 2021, 4:55 p.m. UTC 
From: Minlei Sun <sunml@epoint.com.cn>

Signed-off-by: Minlei Sun <sunml@epoint.com.cn>
---
 libavformat/rtsp.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Moritz Barsnick April 18, 2021, 8:33 p.m. UTC | #1 
On Sun, Apr 18, 2021 at 00:55:26 +0800, sunml@epoint.com.cn wrote:
> From: Minlei Sun <sunml@epoint.com.cn>
>
> Signed-off-by: Minlei Sun <sunml@epoint.com.cn>

These three patches can certainly be squashed - they are of no use
individually.

And you need to amend the documentation (doc/protocols.texi).

Also, I'm not sure whether ignore_rtcp should be one of rtsp_flags. (I
haven't figured out when boolean options are made flags and when not.)

Cheers,
Moritz
diff mbox series

Patch

diff --git a/libavformat/rtsp.h b/libavformat/rtsp.h
index 1310dd9c08..516391673a 100644
--- a/libavformat/rtsp.h
+++ b/libavformat/rtsp.h
@@ -416,6 +416,11 @@  typedef struct RTSPState {
      */
     char *user_agent;
 
+    /**
+     * ignore rtcp data
+     */
+    int ignore_rtcp;
+
     char default_lang[4];
     int buffer_size;
     int pkt_size;