| Message ID | 20210709190232.1428-1-matthias.troffaes@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] configure: enable windres on win32/win64 if available | expand |
| Context | Check | Description |
|---|---|---|
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | success | Make fate finished |
| andriy/PPC64_make | success | Make finished |
| andriy/PPC64_make_fate | success | Make fate finished |
On 7/9/2021 4:02 PM, Matthias C. M. Troffaes wrote: > This patch ensures that MSVC builds under msys will use windres when > available, thereby resulting in the appropriate version and copyright > information to be included in the dlls, as is already the case in the mingw > builds. Wouldn't it make more sense to add support for rc.exe instead? > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure > index b124411609..0fea0bf595 100755 > --- a/configure > +++ b/configure > @@ -5544,6 +5544,7 @@ case $target_os in > enabled x86_64 && objformat="win64" || objformat="win32" > ranlib=: > enable dos_paths > + enabled shared && ! enabled small && test_cmd $windres --version && enable gnu_windres > ;; > cygwin*) > target_os=cygwin >
On Fri, Jul 9, 2021 at 9:27 PM James Almer <jamrial@gmail.com> wrote:
> Wouldn't it make more sense to add support for rc.exe instead?
Yes, that's an excellent point, and I agree that would be better.
Additionally, I've just found the patch breaks the build on some libraries
(at least postproc), my apologies for missing that on submission.
Kind regards,
Matthias
diff --git a/configure b/configure index b124411609..0fea0bf595 100755 --- a/configure +++ b/configure @@ -5544,6 +5544,7 @@ case $target_os in enabled x86_64 && objformat="win64" || objformat="win32" ranlib=: enable dos_paths + enabled shared && ! enabled small && test_cmd $windres --version && enable gnu_windres ;; cygwin*) target_os=cygwin