diff mbox series

[FFmpeg-devel] avformat/isom_tags: fix 'ipcm' with samplesize equal to 16

Message ID tencent_51D13ECD57239CEAE1385B7E352D80C23409@qq.com
State Accepted
Commit 82e3251dd269bdf3c45b991b12dab1ce7561d542
Headers show
Series [FFmpeg-devel] avformat/isom_tags: fix 'ipcm' with samplesize equal to 16 | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Zhao Zhili Oct. 29, 2021, 7:49 a.m. UTC 
Use PCM_S16 so the codec_id will be updated later according to
bits_per_coded_sample.
---
 libavformat/isom_tags.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Zhao Zhili Oct. 29, 2021, 9:17 a.m. UTC | #1 
> On Oct 29, 2021, at 3:49 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
> 
> Use PCM_S16 so the codec_id will be updated later according to
> bits_per_coded_sample.

Here is the sample file:

https://yayunhui-1251820392.cos.ap-beijing.myqcloud.com/zhilizhao/sample/mp4/ipcm-s16.mp4
Paul B Mahol Oct. 29, 2021, 11:53 a.m. UTC | #2 
lgtm
diff mbox series

Patch

diff --git a/libavformat/isom_tags.c b/libavformat/isom_tags.c
index d0400b18fc..62e60470a8 100644
--- a/libavformat/isom_tags.c
+++ b/libavformat/isom_tags.c
@@ -312,10 +312,10 @@  const AVCodecTag ff_codec_movaudio_tags[] = {
     { AV_CODEC_ID_PCM_S16LE,       MKTAG('s', 'o', 'w', 't') },
     { AV_CODEC_ID_PCM_S16BE,       MKTAG('l', 'p', 'c', 'm') },
     { AV_CODEC_ID_PCM_S16LE,       MKTAG('l', 'p', 'c', 'm') },
+    { AV_CODEC_ID_PCM_S16BE,       MKTAG('i', 'p', 'c', 'm') },
+    { AV_CODEC_ID_PCM_S16LE,       MKTAG('i', 'p', 'c', 'm') },
     { AV_CODEC_ID_PCM_S24BE,       MKTAG('i', 'n', '2', '4') },
     { AV_CODEC_ID_PCM_S24LE,       MKTAG('i', 'n', '2', '4') },
-    { AV_CODEC_ID_PCM_S24BE,       MKTAG('i', 'p', 'c', 'm') },
-    { AV_CODEC_ID_PCM_S24LE,       MKTAG('i', 'p', 'c', 'm') },
     { AV_CODEC_ID_PCM_S32BE,       MKTAG('i', 'n', '3', '2') },
     { AV_CODEC_ID_PCM_S32LE,       MKTAG('i', 'n', '3', '2') },
     { AV_CODEC_ID_PCM_S8,          MKTAG('s', 'o', 'w', 't') },