diff mbox

[FFmpeg-devel] avformat/test/fifo_muxer: add check for FailingMuxerPacketData alloc

Message ID 20170105024523.17533-1-lq@chinaffmpeg.org
State Accepted
Commit d1f3e475f9807b445ba37ff2fd23f71c4645de79
Headers show

Commit Message

Liu Steven Jan. 5, 2017, 2:45 a.m. UTC 
CID: 1396257
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavformat/tests/fifo_muxer.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Michael Niedermayer Jan. 5, 2017, 6:02 p.m. UTC | #1 
On Thu, Jan 05, 2017 at 10:45:23AM +0800, Steven Liu wrote:
> CID: 1396257
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
>  libavformat/tests/fifo_muxer.c | 3 +++
>  1 file changed, 3 insertions(+)

LGTM

thx

[...]
Steven Liu Jan. 5, 2017, 10:36 p.m. UTC | #2 
2017-01-06 2:02 GMT+08:00 Michael Niedermayer <michael@niedermayer.cc>:

> On Thu, Jan 05, 2017 at 10:45:23AM +0800, Steven Liu wrote:
> > CID: 1396257
> > Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> > ---
> >  libavformat/tests/fifo_muxer.c | 3 +++
> >  1 file changed, 3 insertions(+)
>
> LGTM
>
applied


Thanks!

>
> thx
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Those who are best at talking, realize last or never when they are wrong.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
diff mbox

Patch

diff --git a/libavformat/tests/fifo_muxer.c b/libavformat/tests/fifo_muxer.c
index dc62965..e20bd6e 100644
--- a/libavformat/tests/fifo_muxer.c
+++ b/libavformat/tests/fifo_muxer.c
@@ -151,6 +151,9 @@  static int prepare_packet(AVPacket *pkt,const FailingMuxerPacketData *pkt_data,
 {
     int ret;
     FailingMuxerPacketData *data = av_malloc(sizeof(*data));
+    if (!data) {
+        return AVERROR(ENOMEM);
+    }
     memcpy(data, pkt_data, sizeof(FailingMuxerPacketData));
     ret = av_packet_from_data(pkt, (uint8_t*) data, sizeof(*data));