diff mbox series

[FFmpeg-devel,04/10] lavc/videotoolboxenc: fix RGB support

Message ID 20211217001215.75135-5-rcombs@rcombs.me
State New
Headers show
Series [FFmpeg-devel,01/10] lavc/videotoolboxenc: use common routine for pixfmt conversion | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

rcombs Dec. 17, 2021, 12:12 a.m. UTC 
---
 libavcodec/videotoolboxenc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rick Kern Dec. 19, 2021, 4:18 p.m. UTC | #1 
On Thu, Dec 16, 2021 at 7:13 PM rcombs <rcombs@rcombs.me> wrote:

> ---
>  libavcodec/videotoolboxenc.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index fa8f717a6c..e10373dded 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec/videotoolboxenc.c
> @@ -1012,6 +1012,9 @@ static int get_cv_ycbcr_matrix(AVCodecContext
> *avctx, CFStringRef *matrix) {
>              *matrix = compat_keys.kCVImageBufferYCbCrMatrix_ITU_R_2020;
>              break;
>
> +        case AVCOL_SPC_RGB:
>
It would be clearer to set the matrix to NULL here (like the
AVCOL_SPC_UNSPECIFIED case).

+            break;
> +
>          default:
>              av_log(avctx, AV_LOG_ERROR, "Color space %s is not
> supported.\n", av_color_space_name(avctx->colorspace));
>              return -1;
> --
> 2.33.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index fa8f717a6c..e10373dded 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -1012,6 +1012,9 @@  static int get_cv_ycbcr_matrix(AVCodecContext *avctx, CFStringRef *matrix) {
             *matrix = compat_keys.kCVImageBufferYCbCrMatrix_ITU_R_2020;
             break;
 
+        case AVCOL_SPC_RGB:
+            break;
+
         default:
             av_log(avctx, AV_LOG_ERROR, "Color space %s is not supported.\n", av_color_space_name(avctx->colorspace));
             return -1;