diff mbox series

[FFmpeg-devel,3/4] avformat/argo_asf: Fix order of operations in error check in argo_asf_write_trailer()

Message ID 20220214193934.22315-3-michael@niedermayer.cc
State Accepted
Commit c8c12fb5d69107f94c5a0be14d0f3646861c60d1
Headers show
Series [FFmpeg-devel,1/4] avformat/matroskadec: Check duration | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Michael Niedermayer Feb. 14, 2022, 7:39 p.m. UTC 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/argo_asf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer Feb. 25, 2022, 9:22 p.m. UTC | #1 
On Mon, Feb 14, 2022 at 08:39:33PM +0100, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/argo_asf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

will apply

[...]
diff mbox series

Patch

diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c
index 2b3569ebc3..d26844d1e2 100644
--- a/libavformat/argo_asf.c
+++ b/libavformat/argo_asf.c
@@ -423,7 +423,7 @@  static int argo_asf_write_trailer(AVFormatContext *s)
     ArgoASFMuxContext *ctx = s->priv_data;
     int64_t ret;
 
-    if ((ret = avio_seek(s->pb, ASF_FILE_HEADER_SIZE, SEEK_SET) < 0))
+    if ((ret = avio_seek(s->pb, ASF_FILE_HEADER_SIZE, SEEK_SET)) < 0)
         return ret;
 
     avio_wl32(s->pb, (uint32_t)ctx->nb_blocks);