| Message ID | 20220805061119.812692-2-fei.w.wang@intel.com |
|---|---|
| State | Accepted |
| Commit | 26890b6b6770214ad63fc9c9564ac75b3227f708 |
| Headers | show |
| Series | [FFmpeg-devel,v2,1/2] doc/filters: correct description of overlay_vaapi | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Fri, 5 Aug 2022 14:11:19 +0800 Fei Wang <fei.w.wang-at-intel.com@ffmpeg.org> wrote: > The present default value of 0 will render the overlay video > invisible. A default of 1.0 is consistent with most common use cases. > > Signed-off-by: Fei Wang <fei.w.wang@intel.com> > --- > doc/filters.texi | 2 +- > libavfilter/vf_overlay_vaapi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index a66b750d57..da0a946a6f 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -26170,7 +26170,7 @@ Default value is the height of input overlay > video. @item alpha > Set transparency of overlaid video. Allowed range is 0.0 to 1.0. > Higher value means lower transparency. > -Default value is @code{0.0}. > +Default value is @code{1.0}. > > @end table > > diff --git a/libavfilter/vf_overlay_vaapi.c > b/libavfilter/vf_overlay_vaapi.c index b3a624ae15..3e6a0de13f 100644 > --- a/libavfilter/vf_overlay_vaapi.c > +++ b/libavfilter/vf_overlay_vaapi.c > @@ -380,7 +380,7 @@ static const AVOption overlay_vaapi_options[] = { > { "h", "Overlay height", > OFFSET(overlay_oh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, > .flags = FLAGS }, { "alpha", "Overlay global alpha", > - OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 0.0}, 0.0, 1.0, > .flags = FLAGS}, > + OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 1.0}, 0.0, 1.0, > .flags = FLAGS}, { NULL }, > }; > LGTM --phil
diff --git a/doc/filters.texi b/doc/filters.texi index a66b750d57..da0a946a6f 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -26170,7 +26170,7 @@ Default value is the height of input overlay video. @item alpha Set transparency of overlaid video. Allowed range is 0.0 to 1.0. Higher value means lower transparency. -Default value is @code{0.0}. +Default value is @code{1.0}. @end table diff --git a/libavfilter/vf_overlay_vaapi.c b/libavfilter/vf_overlay_vaapi.c index b3a624ae15..3e6a0de13f 100644 --- a/libavfilter/vf_overlay_vaapi.c +++ b/libavfilter/vf_overlay_vaapi.c @@ -380,7 +380,7 @@ static const AVOption overlay_vaapi_options[] = { { "h", "Overlay height", OFFSET(overlay_oh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, .flags = FLAGS }, { "alpha", "Overlay global alpha", - OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 0.0}, 0.0, 1.0, .flags = FLAGS}, + OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 1.0}, 0.0, 1.0, .flags = FLAGS}, { NULL }, };
The present default value of 0 will render the overlay video invisible. A default of 1.0 is consistent with most common use cases. Signed-off-by: Fei Wang <fei.w.wang@intel.com> --- doc/filters.texi | 2 +- libavfilter/vf_overlay_vaapi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)