diff mbox series

[FFmpeg-devel,1/4,v2] avcodec/librav1e: support setting sample aspect ratio

Message ID 20221012130829.2392-1-jamrial@gmail.com
State Accepted
Commit d569958d2952ac5b5ed4334ffba04bfe1a55a967
Headers show
Series [FFmpeg-devel,1/4,v2] avcodec/librav1e: support setting sample aspect ratio | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

James Almer Oct. 12, 2022, 1:08 p.m. UTC
Signed-off-by: James Almer <jamrial@gmail.com>
---
Changes since v1:
- Ensure we're not passing values like 0/1 as they are not supported by
  librav1e.

 libavcodec/librav1e.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

James Almer Oct. 18, 2022, 10:38 p.m. UTC | #1
On 10/12/2022 10:08 AM, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> Changes since v1:
> - Ensure we're not passing values like 0/1 as they are not supported by
>    librav1e.
> 
>   libavcodec/librav1e.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c
> index 0601efed2c..a13d6c9eaf 100644
> --- a/libavcodec/librav1e.c
> +++ b/libavcodec/librav1e.c
> @@ -298,6 +298,12 @@ static av_cold int librav1e_encode_init(AVCodecContext *avctx)
>           goto end;
>       }
>   
> +    if (avctx->sample_aspect_ratio.num > 0 && avctx->sample_aspect_ratio.den > 0)
> +        rav1e_config_set_sample_aspect_ratio(cfg, (RaRational) {
> +                                             avctx->sample_aspect_ratio.num,
> +                                             avctx->sample_aspect_ratio.den
> +                                             });
> +
>       rret = rav1e_config_parse_int(cfg, "threads", avctx->thread_count);
>       if (rret < 0)
>           av_log(avctx, AV_LOG_WARNING, "Invalid number of threads, defaulting to auto.\n");

Will apply set.
diff mbox series

Patch

diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c
index 0601efed2c..a13d6c9eaf 100644
--- a/libavcodec/librav1e.c
+++ b/libavcodec/librav1e.c
@@ -298,6 +298,12 @@  static av_cold int librav1e_encode_init(AVCodecContext *avctx)
         goto end;
     }
 
+    if (avctx->sample_aspect_ratio.num > 0 && avctx->sample_aspect_ratio.den > 0)
+        rav1e_config_set_sample_aspect_ratio(cfg, (RaRational) {
+                                             avctx->sample_aspect_ratio.num,
+                                             avctx->sample_aspect_ratio.den
+                                             });
+
     rret = rav1e_config_parse_int(cfg, "threads", avctx->thread_count);
     if (rret < 0)
         av_log(avctx, AV_LOG_WARNING, "Invalid number of threads, defaulting to auto.\n");