Message ID | 20221106123430.1668-7-michael@niedermayer.cc |
---|---|
State | Accepted |
Commit | 8e59e72041360240f60db9c04aecc2143102f0cc |
Headers | show |
Series | [FFmpeg-devel,1/7] avcodec/bonk: Use unsigned in predictor_calc_error() to avoid undefined overflows | expand |
Context | Check | Description |
---|---|---|
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
On 11/6/22, Michael Niedermayer <michael@niedermayer.cc> wrote: > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavcodec/bonk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c > index f2427de4f1..c775ed5ddf 100644 > --- a/libavcodec/bonk.c > +++ b/libavcodec/bonk.c > @@ -169,8 +169,7 @@ static int intlist_read(BonkContext *s, int *buf, int > entries, int base_2_part) > return AVERROR_INVALIDDATA; > > if (!get_bits1(&s->gb)) { > - if (steplet < 0) > - break; > + av_assert0(steplet >= 0); > > if (steplet > 0) { > bits[x ].bit = dominant; > -- > 2.17.1 > probably fine > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >
diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c index f2427de4f1..c775ed5ddf 100644 --- a/libavcodec/bonk.c +++ b/libavcodec/bonk.c @@ -169,8 +169,7 @@ static int intlist_read(BonkContext *s, int *buf, int entries, int base_2_part) return AVERROR_INVALIDDATA; if (!get_bits1(&s->gb)) { - if (steplet < 0) - break; + av_assert0(steplet >= 0); if (steplet > 0) { bits[x ].bit = dominant;
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/bonk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)