| Message ID | 20220713000217.257584-1-stefasab@gmail.com |
|---|---|
| State | Accepted |
| Commit | b6219c91144e665c98ceda9189e5f2bf75232fa8 |
| Headers | show |
| Series | [FFmpeg-devel] ffprobe: use pkt->dts to compute interval ts when pts is missing | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: > For some samples the pkt->pts is always missing, use the pkt->dts > instead. > > Fix trac issue http://trac.ffmpeg.org/ticket/4427. > --- > fftools/ffprobe.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Updated.
On date Saturday 2022-12-31 20:26:34 +0100, Stefano Sabatini wrote: > On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: > > For some samples the pkt->pts is always missing, use the pkt->dts > > instead. > > > > Fix trac issue http://trac.ffmpeg.org/ticket/4427. > > --- > > fftools/ffprobe.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > Updated. Ping. (Also I lost my push permissions, I'm happy to regain my write access if you know who I should contact/what should I do to get it back).
On Sun, Jan 15, 2023 at 02:25:40AM +0100, Stefano Sabatini wrote: > On date Saturday 2022-12-31 20:26:34 +0100, Stefano Sabatini wrote: > > On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: > > > For some samples the pkt->pts is always missing, use the pkt->dts > > > instead. > > > > > > Fix trac issue http://trac.ffmpeg.org/ticket/4427. > > > --- > > > fftools/ffprobe.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > Updated. > > Ping. (Also I lost my push permissions, I'm happy to regain my write > access if you know who I should contact/what should I do to get it > back). you lost your ssh key ? if so send me a new public ssh key signed with the gpg key listed in MAINTAINERs PS: also tell me if the old key is lost (as in, should be removed) thx [...]
> On Jan 1, 2023, at 03:26, Stefano Sabatini <stefasab@gmail.com> wrote: > > On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: >> For some samples the pkt->pts is always missing, use the pkt->dts >> instead. If some pkt->pts is missing but isn’t always missing, isn’t it mixed the use of pts and dts? I don’t have a particular case in mind yet. >> >> Fix trac issue http://trac.ffmpeg.org/ticket/4427. >> --- >> fftools/ffprobe.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > Updated. > <0001-ffprobe-use-pkt-dts-to-compute-interval-ts-when-pts-.patch>_______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On date Monday 2023-01-16 11:01:51 +0800, "zhilizhao(赵志立)" wrote: > > > On Jan 1, 2023, at 03:26, Stefano Sabatini <stefasab@gmail.com> wrote: > > > > On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: > >> For some samples the pkt->pts is always missing, use the pkt->dts > >> instead. > > If some pkt->pts is missing but isn’t always missing, isn’t it mixed > the use of pts and dts? I don’t have a particular case in mind yet. In the ticket sample, it was missing all the PTSs, so the only time reference was provided by the DTSs (note that this only affects the -read_intervals option). I have no better ideas. > >> > >> Fix trac issue http://trac.ffmpeg.org/ticket/4427.
> On Jan 17, 2023, at 07:41, Stefano Sabatini <stefasab@gmail.com> wrote: > > On date Monday 2023-01-16 11:01:51 +0800, "zhilizhao(赵志立)" wrote: >> >>> On Jan 1, 2023, at 03:26, Stefano Sabatini <stefasab@gmail.com> wrote: >>> >>> On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: >>>> For some samples the pkt->pts is always missing, use the pkt->dts >>>> instead. >> >> If some pkt->pts is missing but isn’t always missing, isn’t it mixed >> the use of pts and dts? I don’t have a particular case in mind yet. > > In the ticket sample, it was missing all the PTSs, so the only time > reference was provided by the DTSs (note that this only affects the > -read_intervals option). I have no better ideas. Looks like there is no better choices, patch LGTM. > >>>> >>>> Fix trac issue http://trac.ffmpeg.org/ticket/4427. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On date Tuesday 2023-01-17 10:57:58 +0800, "zhilizhao(赵志立)" wrote: > > On Jan 17, 2023, at 07:41, Stefano Sabatini <stefasab@gmail.com> wrote: > > > > On date Monday 2023-01-16 11:01:51 +0800, "zhilizhao(赵志立)" wrote: > >> > >>> On Jan 1, 2023, at 03:26, Stefano Sabatini <stefasab@gmail.com> wrote: > >>> > >>> On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: > >>>> For some samples the pkt->pts is always missing, use the pkt->dts > >>>> instead. > >> > >> If some pkt->pts is missing but isn’t always missing, isn’t it mixed > >> the use of pts and dts? I don’t have a particular case in mind yet. > > > > In the ticket sample, it was missing all the PTSs, so the only time > > reference was provided by the DTSs (note that this only affects the > > -read_intervals option). I have no better ideas. > > Looks like there is no better choices, patch LGTM. Applied.
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index f156663019..8824b1c044 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2844,9 +2844,10 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile, } if (selected_streams[pkt->stream_index]) { AVRational tb = ifile->streams[pkt->stream_index].st->time_base; + int64_t pts = pkt->pts != AV_NOPTS_VALUE ? pkt->pts : pkt->dts; - if (pkt->pts != AV_NOPTS_VALUE) - *cur_ts = av_rescale_q(pkt->pts, tb, AV_TIME_BASE_Q); + if (pts != AV_NOPTS_VALUE) + *cur_ts = av_rescale_q(pts, tb, AV_TIME_BASE_Q); if (!has_start && *cur_ts != AV_NOPTS_VALUE) { start = *cur_ts;