diff mbox series

[FFmpeg-devel,6/8] lavc/libvpxenc: drop a useless condition

Message ID 20230228120104.2347-6-anton@khirnov.net
State Accepted
Commit 62a241e505abfa96b4329875ecc76aaa1d57519e
Headers show
Series [FFmpeg-devel,1/8] lavu/frame: improve AVFrame.opaque[_ref] documentation | expand

Checks

Context Check Description
yinshiyou/configure_loongarch64 warning Failed to apply patch
andriy/configure_x86 warning Failed to apply patch

Commit Message

Anton Khirnov Feb. 28, 2023, 12:01 p.m. UTC 
A non-NULL packet is always passed to frame_data_apply().
---
 libavcodec/libvpxenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Zern Feb. 28, 2023, 9:12 p.m. UTC | #1 
On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov <anton@khirnov.net> wrote:
>
> A non-NULL packet is always passed to frame_data_apply().
> ---
>  libavcodec/libvpxenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

lgtm

> diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c
> index af16e53deb..33f35bbaf4 100644
> --- a/libavcodec/libvpxenc.c
> +++ b/libavcodec/libvpxenc.c
> @@ -401,7 +401,7 @@ static int frame_data_apply(AVCodecContext *avctx, AVFifo *fifo, AVPacket *pkt)
>  {
>      FrameData fd;
>      uint8_t *data;
> -    if (!pkt || av_fifo_peek(fifo, &fd, 1, 0) < 0)
> +    if (av_fifo_peek(fifo, &fd, 1, 0) < 0)
>          return 0;
>      if (fd.pts != pkt->pts)
>          return 0;
> --
> 2.39.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c
index af16e53deb..33f35bbaf4 100644
--- a/libavcodec/libvpxenc.c
+++ b/libavcodec/libvpxenc.c
@@ -401,7 +401,7 @@  static int frame_data_apply(AVCodecContext *avctx, AVFifo *fifo, AVPacket *pkt)
 {
     FrameData fd;
     uint8_t *data;
-    if (!pkt || av_fifo_peek(fifo, &fd, 1, 0) < 0)
+    if (av_fifo_peek(fifo, &fd, 1, 0) < 0)
         return 0;
     if (fd.pts != pkt->pts)
         return 0;