diff mbox

[FFmpeg-devel,2/2] cmdutils: print a more descriptive error message in show_help_bsf() when no bsf is specified

Message ID 20180728035848.1932-2-jamrial@gmail.com
State Accepted
Commit d228df6ff3597928acf76d7ae922c1ec7d2c0b0f
Headers show

Commit Message

James Almer July 28, 2018, 3:58 a.m. UTC 
Signed-off-by: James Almer <jamrial@gmail.com>
---
 fftools/cmdutils.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Michael Niedermayer July 28, 2018, 1:11 p.m. UTC | #1 
On Sat, Jul 28, 2018 at 12:58:48AM -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  fftools/cmdutils.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

LGTM

thx

[...]
James Almer July 28, 2018, 4:25 p.m. UTC | #2 
On 7/28/2018 10:11 AM, Michael Niedermayer wrote:
> On Sat, Jul 28, 2018 at 12:58:48AM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  fftools/cmdutils.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> LGTM
> 
> thx

Pushed, thanks.
diff mbox

Patch

diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index b8de319fe4..9cfbc45c2b 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -1956,7 +1956,10 @@  static void show_help_bsf(const char *name)
 {
     const AVBitStreamFilter *bsf = av_bsf_get_by_name(name);
 
-    if (!bsf) {
+    if (!name) {
+        av_log(NULL, AV_LOG_ERROR, "No bitstream filter name specified.\n");
+        return;
+    } else if (!bsf) {
         av_log(NULL, AV_LOG_ERROR, "Unknown bit stream filter '%s'.\n", name);
         return;
     }