| Message ID | 20220101011148.13921-1-jpstewart@personalprojects.net |
|---|---|
| Headers | show |
| Series | avformat/mvdec: make audio stream conditional | expand |
On Fri, Dec 31, 2021 at 08:11:46PM -0500, John-Paul Stewart wrote: > Changed in v2: > Allocate the audio stream first to maintain consistent behaviour > with prior code. > > Recent discussion on the list led me to realize that libavformat was > unconditionally creating an audio stream for all SGI movie format > (version 2) files, even when no audio is present in the file. > > A sample of a movie file with no audio can be found at > http://www.personalprojects.net/ffmpeg/silent.movie > > Unpatched ffmpeg will report an audio stream even though no audio is > present. After the following patch no audio stream is reported. > > Incidentally, the silent.movie sample above is at 25fps and can also be > used by anyone who wants to double-check the earlier patch 3c9ffbd009 > that reads and sets the framerate. The sample file is only about 88 KB. v2 patchset looks good to me. I will apply in a couple of days. Thanks. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
Changed in v2: Allocate the audio stream first to maintain consistent behaviour with prior code. Recent discussion on the list led me to realize that libavformat was unconditionally creating an audio stream for all SGI movie format (version 2) files, even when no audio is present in the file. A sample of a movie file with no audio can be found at http://www.personalprojects.net/ffmpeg/silent.movie Unpatched ffmpeg will report an audio stream even though no audio is present. After the following patch no audio stream is reported. Incidentally, the silent.movie sample above is at 25fps and can also be used by anyone who wants to double-check the earlier patch 3c9ffbd009 that reads and sets the framerate. The sample file is only about 88 KB.